ldb:ldb_msg.c - use LDB result constants for checking return values

Reviewed by: Tridge

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Mar  4 22:51:57 CET 2011 on sn-devel-104

diff --git a/source4/lib/ldb/common/ldb_msg.c b/source4/lib/ldb/common/ldb_msg.c
index 8b51ad087cb58f1049f361b9c772e37fc6605344..d1c77f89bc8c9bf44407040099765a7803ab9312 100644 (file)
--- a/source4/lib/ldb/common/ldb_msg.c
+++ b/source4/lib/ldb/common/ldb_msg.c
@@ -890,11 +890,14 @@ int ldb_msg_rename_attr(struct ldb_message *msg, const char *attr, const char *r
 int ldb_msg_copy_attr(struct ldb_message *msg, const char *attr, const char *replace)
 {
        struct ldb_message_element *el = ldb_msg_find_element(msg, attr);
+       int ret;
+
        if (el == NULL) {
                return LDB_SUCCESS;
        }
-       if (ldb_msg_add(msg, el, 0) != 0) {
-               return LDB_ERR_OPERATIONS_ERROR;
+       ret = ldb_msg_add(msg, el, 0);
+       if (ret != LDB_SUCCESS) {
+               return ret;
        }
        return ldb_msg_rename_attr(msg, attr, replace);
 }