s4-torture: Fix logic errors in node and group control clusapi tests.
authorGünther Deschner <gd@samba.org>
Mon, 2 May 2016 15:53:38 +0000 (17:53 +0200)
committerJeremy Allison <jra@samba.org>
Wed, 7 Sep 2016 21:56:15 +0000 (23:56 +0200)
Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source4/torture/rpc/clusapi.c

index 986f263065ab5de0980891e9577ec1e66b02c53f..7b7e06aa07107be360fbf0f34370ff85f94a2289 100644 (file)
@@ -1522,12 +1522,12 @@ static bool test_NodeControl(struct torture_context *tctx,
        }
 
        ret = test_NodeControl_int(tctx, t->p, &hNode, CLUSCTL_NODE_GET_RO_COMMON_PROPERTIES);
-       if (ret) {
+       if (!ret) {
                return false;
        }
 
        ret = test_NodeControl_int(tctx, t->p, &hNode, CLUSCTL_NODE_GET_ID);
-       if (ret) {
+       if (!ret) {
                return false;
        }
 
@@ -2006,12 +2006,12 @@ static bool test_GroupControl(struct torture_context *tctx,
        }
 
        ret = test_GroupControl_int(tctx, t->p, &hGroup, CLUSCTL_GROUP_GET_CHARACTERISTICS);
-       if (ret) {
+       if (!ret) {
                return false;
        }
 
        ret = test_GroupControl_int(tctx, t->p, &hGroup, CLUSCTL_GROUP_GET_RO_COMMON_PROPERTIES);
-       if (ret) {
+       if (!ret) {
                return false;
        }