ARM: mxs: Use of_property_present() for testing DT property presence
authorRob Herring <robh@kernel.org>
Fri, 10 Mar 2023 14:46:54 +0000 (08:46 -0600)
committerShawn Guo <shawnguo@kernel.org>
Tue, 14 Mar 2023 07:05:52 +0000 (15:05 +0800)
It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.

Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
arch/arm/mach-mxs/mach-mxs.c

index 0129b7c514d755735eeadf678cbebdf1f658ed7a..51e47053c81667d7d89dce10f518e02c241f2146 100644 (file)
@@ -174,7 +174,7 @@ static void __init update_fec_mac_prop(enum mac_oui oui)
 
                from = np;
 
-               if (of_get_property(np, "local-mac-address", NULL))
+               if (of_property_present(np, "local-mac-address"))
                        continue;
 
                newmac = kzalloc(sizeof(*newmac) + 6, GFP_KERNEL);