tests: Add test_echo_tcp_connect test.

This tests some corner cases we fixed in the past.

diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
index 23f362d7d6218c7a7519f72549e115b237b28df9..71acff5c5749ccbf0068443ee32e6a75029b6af6 100644 (file)
--- a/tests/CMakeLists.txt
+++ b/tests/CMakeLists.txt
@@ -17,7 +17,13 @@ target_link_libraries(${TORTURE_LIBRARY}
     ${CMOCKA_LIBRARY}
     ${SWRAP_REQUIRED_LIBRARIES})
 
-set(SWRAP_TESTS test_ioctl test_echo_udp_sendto_recvfrom test_echo_udp_send_recv test_echo_tcp_write_read test_echo_tcp_writev_readv)
+set(SWRAP_TESTS
+    test_ioctl
+    test_echo_tcp_connect
+    test_echo_tcp_write_read
+    test_echo_tcp_writev_readv
+    test_echo_udp_sendto_recvfrom
+    test_echo_udp_send_recv)
 
 foreach(_SWRAP_TEST ${SWRAP_TESTS})
     add_cmocka_test(${_SWRAP_TEST} ${_SWRAP_TEST}.c ${TORTURE_LIBRARY})

diff --git a/tests/test_echo_tcp_connect.c b/tests/test_echo_tcp_connect.c
new file mode 100644 (file)
index 0000000..b20e453
--- /dev/null
+++ b/tests/test_echo_tcp_connect.c
@@ -0,0 +1,95 @@
+#include <stdarg.h>
+#include <stddef.h>
+#include <setjmp.h>
+#include <cmocka.h>
+
+#include "config.h"
+#include "torture.h"
+
+#include <errno.h>
+#include <sys/types.h>
+#include <sys/socket.h>
+#include <netinet/in.h>
+#include <arpa/inet.h>
+#include <stdlib.h>
+#include <stdio.h>
+#include <unistd.h>
+
+static void setup_echo_srv_tcp_ipv4(void **state)
+{
+       torture_setup_echo_srv_tcp_ipv4(state);
+}
+
+static void teardown(void **state)
+{
+       torture_teardown_echo_srv(state);
+}
+
+static void test_connect_broadcast_ipv4(void **state)
+{
+       struct sockaddr_in sin;
+       socklen_t slen = sizeof(struct sockaddr_in);
+       int rc;
+       int s;
+
+       (void) state; /* unused */
+
+       s = socket(AF_INET, SOCK_STREAM, IPPROTO_TCP);
+       assert_int_not_equal(s, -1);
+
+       ZERO_STRUCT(sin);
+       sin.sin_family = AF_INET;
+       sin.sin_port = htons(torture_server_port());
+       sin.sin_addr.s_addr = INADDR_BROADCAST;
+
+       /* We don't allow connect to broadcast addresses */
+       rc = connect(s, (struct sockaddr *)&sin, slen);
+       assert_int_equal(rc, -1);
+
+       close(s);
+}
+
+#ifdef HAVE_IPV6
+static void test_connect_downgrade_ipv6(void **state)
+{
+       struct sockaddr_in sin;
+       socklen_t slen = sizeof(struct sockaddr_in);
+       int rc;
+       int s;
+
+       (void) state; /* unused */
+
+       s = socket(AF_INET6, SOCK_STREAM, IPPROTO_TCP);
+       assert_int_not_equal(s, -1);
+
+       ZERO_STRUCT(sin);
+       sin.sin_family = AF_INET;
+       sin.sin_port = htons(torture_server_port());
+
+       rc = inet_pton(sin.sin_family,
+                      torture_server_address(AF_INET),
+                      &sin.sin_addr);
+       assert_int_equal(rc, 1);
+
+       /* Connect should downgrade to IPv4 and allow the connect */
+       rc = connect(s, (struct sockaddr *)&sin, slen);
+       assert_int_equal(rc, 0);
+
+       close(s);
+}
+#endif
+
+int main(void) {
+       int rc;
+
+       const UnitTest tests[] = {
+               unit_test_setup_teardown(test_connect_broadcast_ipv4, setup_echo_srv_tcp_ipv4, teardown),
+#ifdef HAVE_IPV6
+               unit_test_setup_teardown(test_connect_downgrade_ipv6, setup_echo_srv_tcp_ipv4, teardown),
+#endif
+       };
+
+       rc = run_tests(tests);
+
+       return rc;
+}