s4-kcc: Do not dereference a NULL pointer
authorAndreas Schneider <asn@samba.org>
Thu, 16 Feb 2017 16:08:50 +0000 (17:08 +0100)
committerJeremy Allison <jra@samba.org>
Thu, 23 Feb 2017 02:18:10 +0000 (03:18 +0100)
Found by covscan.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12592

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source4/dsdb/kcc/garbage_collect_tombstones.c

index 1909cfeff76c7631e63fea688279a0d16c858b22..d8d0a5995c252a33bb885f5ed4a9ee0bd1440a39 100644 (file)
@@ -137,7 +137,9 @@ static NTSTATUS garbage_collect_tombstones_part(TALLOC_CTX *mem_ctx,
                                                                   element->name);
 
                        /* This avoids parsing isDeleted as a link */
-                       if (attrib->linkID == 0 || ((attrib->linkID & 1) == 1)) {
+                       if (attrib == NULL ||
+                           attrib->linkID == 0 ||
+                           ((attrib->linkID & 1) == 1)) {
                                continue;
                        }