libcli: Use GUID_to_ndr_buf() in smbXcli_negprot_smb2_subreq()
authorVolker Lendecke <vl@samba.org>
Tue, 29 Sep 2020 08:53:42 +0000 (10:53 +0200)
committerJeremy Allison <jra@samba.org>
Fri, 2 Oct 2020 21:30:34 +0000 (21:30 +0000)
Avoid a talloc/free

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
libcli/smb/smbXcli_base.c

index 7d2da4b9ebc2f920815f31d362016991c1b3d860..687a9896b48995661faad0836fefeb0cc2228a7e 100644 (file)
@@ -4749,14 +4749,14 @@ static struct tevent_req *smbXcli_negprot_smb2_subreq(struct smbXcli_negprot_sta
        }
        if (state->conn->max_protocol >= PROTOCOL_SMB2_10) {
                NTSTATUS status;
-               DATA_BLOB blob;
+               struct GUID_ndr_buf guid_buf = { .buf = {0}, };
 
-               status = GUID_to_ndr_blob(&state->conn->smb2.client.guid,
-                                         state, &blob);
+               status = GUID_to_ndr_buf(&state->conn->smb2.client.guid,
+                                        &guid_buf);
                if (!NT_STATUS_IS_OK(status)) {
                        return NULL;
                }
-               memcpy(buf+12, blob.data, 16); /* ClientGuid */
+               memcpy(buf+12, guid_buf.buf, 16); /* ClientGuid */
        } else {
                memset(buf+12, 0, 16);  /* ClientGuid */
        }