MIPS: cevt-r4k: Offset the value used to clear compare interrupt
authorJiaxun Yang <jiaxun.yang@flygoat.com>
Mon, 27 Feb 2023 18:46:14 +0000 (18:46 +0000)
committerThomas Bogendoerfer <tsbogend@alpha.franken.de>
Mon, 27 Feb 2023 22:45:17 +0000 (23:45 +0100)
In c0_compare_int_usable we clear compare interrupt by write value
just read out from counter to compare register.

However sometimes if those all instructions are graduated together
then it's possible that at the time compare register is written, the
counter haven't progressed, thus the interrupt is triggered again.

It also applies to QEMU that instructions is executed significantly
faster then counter.

Offset the value used to clear interrupt by one to prevent that happen.

Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
arch/mips/kernel/cevt-r4k.c

index 32ec67c9ab67bbdcc14f3ed3c36792b6a17e060d..368e8475870f0810be1a707266c357c06b51ffd1 100644 (file)
@@ -200,7 +200,7 @@ int c0_compare_int_usable(void)
         */
        if (c0_compare_int_pending()) {
                cnt = read_c0_count();
-               write_c0_compare(cnt);
+               write_c0_compare(cnt - 1);
                back_to_back_c0_hazard();
                while (read_c0_count() < (cnt  + COMPARE_INT_SEEN_TICKS))
                        if (!c0_compare_int_pending())
@@ -228,7 +228,7 @@ int c0_compare_int_usable(void)
        if (!c0_compare_int_pending())
                return 0;
        cnt = read_c0_count();
-       write_c0_compare(cnt);
+       write_c0_compare(cnt - 1);
        back_to_back_c0_hazard();
        while (read_c0_count() < (cnt + COMPARE_INT_SEEN_TICKS))
                if (!c0_compare_int_pending())