CVE-2023-3347: smbd: remove comment in smbd_smb2_request_process_negprot()
authorRalph Boehme <slow@samba.org>
Tue, 20 Jun 2023 16:13:23 +0000 (18:13 +0200)
committerJule Anger <janger@samba.org>
Fri, 21 Jul 2023 12:05:35 +0000 (12:05 +0000)
This is just going to bitrot. Anyone who's interested can just grep for
"signing_mandatory" and look up what it does.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15397

Signed-off-by: Ralph Boehme <slow@samba.org>
source3/smbd/smb2_negprot.c

index 9d4ce160e5c9574d04d0a56e4fc606910a844d82..885769be24d53779b20f5dd885656ef9c1de35e5 100644 (file)
@@ -368,12 +368,6 @@ NTSTATUS smbd_smb2_request_process_negprot(struct smbd_smb2_request *req)
        }
 
        security_mode = SMB2_NEGOTIATE_SIGNING_ENABLED;
-       /*
-        * We use xconn->smb2.signing_mandatory set up via
-        * srv_init_signing() -> smb2_srv_init_signing().
-        * This calls lpcfg_server_signing_allowed() to get the correct
-        * defaults, e.g. signing_required for an ad_dc.
-        */
        if (xconn->smb2.signing_mandatory) {
                security_mode |= SMB2_NEGOTIATE_SIGNING_REQUIRED;
        }