clitar.c: Fixed minor gcc -pedantic-error compile warnings.

passdb.c: Fixed stupid bug in read_sid_from_file().
Jeremy.
(This used to be commit e65efe3f78240a4fa1ed7931e96c6fb698d9d8c8)

diff --git a/source3/client/clitar.c b/source3/client/clitar.c
index 412af8fa83b55f48d0ba5386d101ea97c8454639..b06b5b2d37d9a464402f5477db4579851588d728 100644 (file)
--- a/source3/client/clitar.c
+++ b/source3/client/clitar.c
@@ -307,7 +307,7 @@ static long readtarheader(union hblock *hb, file_info2 *finfo, char *prefix)
       }
       fprintf(stdout, "\n");
       fprintf(stdout, "%s\n", hb -> dummy);
-      fprintf(stdout, "Tarbuf = %X, hb = %X\n", tarbuf, hb);
+      fprintf(stdout, "Tarbuf = %X, hb = %X\n", (int)tarbuf, (int)hb);
       return -1;
     }
 
@@ -2309,7 +2309,6 @@ static int read_inclusion_file(char *filename)
   char *p;
   char *tmpstr;
   int i;
-  int result = 0;
   int error = 0;
 
   clipn = 0;
@@ -2388,10 +2387,10 @@ static int read_inclusion_file(char *filename)
   }
   if (error) {
     if (cliplist) {
-      char **p;
+      char **pp;
       /* We know cliplist is always null-terminated */
-      for (p = cliplist; *p; ++p) {
-       free(*p);
+      for (pp = cliplist; *pp; ++pp) {
+        free(*pp);
       }
       free(cliplist);
       cliplist = NULL;

diff --git a/source3/passdb/passdb.c b/source3/passdb/passdb.c
index 2ba856e19be5d7877feb8e87a78acf469544d3af..cc4a8e5c55118256d0d63ac2d7797ea81b296e95 100644 (file)
--- a/source3/passdb/passdb.c
+++ b/source3/passdb/passdb.c
@@ -874,6 +874,8 @@ static BOOL read_sid_from_file(int fd, char *sid_file)
 {   
   fstring fline;
     
+  memset(fline, '\0', sizeof(fline));
+
   if(read(fd, fline, sizeof(fline) -1 ) < 0) {
     DEBUG(0,("read_sid_from_file: unable to read file %s. Error was %s\n",
            sid_file, strerror(errno) ));