drm: of: Fix linking when CONFIG_OF is not set
authorLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Thu, 19 Dec 2019 10:37:03 +0000 (12:37 +0200)
committerDave Airlie <airlied@redhat.com>
Thu, 9 Jan 2020 00:40:58 +0000 (10:40 +1000)
The new helper drm_of_lvds_get_dual_link_pixel_order() introduced in
commit 6529007522de has a fallback stub when CONFIG_OF is not set, but
the stub is declared in drm_of.h without a static inline. This causes
multiple definitions of the function to be linked when the CONFIG_OF
option isn't set. Fix it by making the stub static inline.

Fixes: 6529007522de ("drm: of: Add drm_of_lvds_get_dual_link_pixel_order")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191219103703.8547-1-laurent.pinchart+renesas@ideasonboard.com
include/drm/drm_of.h

index 8ec7ca6d2369292bd0b8956d9a57620869a9afd9..b9b093add92e792555778084472c536ffd897367 100644 (file)
@@ -92,8 +92,9 @@ static inline int drm_of_find_panel_or_bridge(const struct device_node *np,
        return -EINVAL;
 }
 
-int drm_of_lvds_get_dual_link_pixel_order(const struct device_node *port1,
-                                         const struct device_node *port2)
+static inline int
+drm_of_lvds_get_dual_link_pixel_order(const struct device_node *port1,
+                                     const struct device_node *port2)
 {
        return -EINVAL;
 }