ASoC: atmel-pdmic: Remove endianness flag on pdmic component
authorCharles Keepax <ckeepax@opensource.cirrus.com>
Wed, 4 May 2022 17:08:29 +0000 (18:08 +0100)
committerMark Brown <broonie@kernel.org>
Mon, 9 May 2022 11:46:07 +0000 (12:46 +0100)
The endianness flag should have been removed when the driver was
ported across from having both a CODEC and CPU side component, to
just having a CPU component and using the dummy for the CODEC. The
endianness flag is used to indicate that the device is completely
ambivalent to the endianness of the data, typically due to the
endianness being lost over the hardware link (ie. the link defines
bit ordering). It's usage didn't have any effect when the driver
had both a CPU and CODEC component, since the union of those equals
the CPU side settings, but now causes the driver to falsely report
it supports big endian. Correct this by removing the flag.

Fixes: f3c668074a04 ("ASoC: atmel-pdmic: remove codec component")
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20220504170905.332415-3-ckeepax@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/atmel/atmel-pdmic.c

index 42117de299e7469daf15dd0c89f2bc776058d7d8..ea34efac2fff5133a6d36c44711f2f9619fbe5ad 100644 (file)
@@ -481,7 +481,6 @@ static const struct snd_soc_component_driver atmel_pdmic_cpu_dai_component = {
        .num_controls           = ARRAY_SIZE(atmel_pdmic_snd_controls),
        .idle_bias_on           = 1,
        .use_pmdown_time        = 1,
-       .endianness             = 1,
 };
 
 /* ASoC sound card */