media: atomisp: Drop unnecessary first_streamoff check
authorHans de Goede <hdegoede@redhat.com>
Sun, 4 Sep 2022 08:56:47 +0000 (10:56 +0200)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Sat, 24 Sep 2022 08:11:35 +0000 (10:11 +0200)
Drop an unnecessary first_streamoff check from atomisp_streamoff(),
above the check there is a:

if (!first_streamoff)
goto stop_sensor;

Code block which will jump over the code with the test, so the test
is only executed when first_streamoff is true and therefor the test
is not necessary.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/staging/media/atomisp/pci/atomisp_ioctl.c

index ed3ec603a713da5bd44de1db049c085da180ddea..77c0d55ab409c4cb8fe367b9dcbb87850c9b0428 100644 (file)
@@ -1880,10 +1880,10 @@ int atomisp_streamoff(struct file *file, void *fh, enum v4l2_buf_type type)
                cancel_work_sync(&asd->delayed_init_work);
                asd->delayed_init = ATOMISP_DELAYED_INIT_NOT_QUEUED;
        }
-       if (first_streamoff) {
-               css_pipe_id = atomisp_get_css_pipe_id(asd);
-               atomisp_css_stop(asd, css_pipe_id, false);
-       }
+
+       css_pipe_id = atomisp_get_css_pipe_id(asd);
+       atomisp_css_stop(asd, css_pipe_id, false);
+
        /* cancel work queue*/
        if (asd->video_out_capture.users) {
                capture_pipe = &asd->video_out_capture;