ntlmssp: fix compilation with -O2 -fno-inline

Without inlining the function, GCC doesn't know that
gensec_ntlmssp->ntlmssp_state->role always has a valid value.

With inlining, this is obviously redundant but GCC clearly knows
enough to detect this and elide the default case.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/auth/ntlmssp/ntlmssp.c b/auth/ntlmssp/ntlmssp.c
index 4abab88627ad478c5f15ddd923af5d41297cf3db..3283c964470811931e9624344c6b41a61dec5b77 100644 (file)
--- a/auth/ntlmssp/ntlmssp.c
+++ b/auth/ntlmssp/ntlmssp.c
@@ -107,6 +107,10 @@ static NTSTATUS gensec_ntlmssp_update_find(struct gensec_security *gensec_securi
                                return NT_STATUS_INVALID_PARAMETER;
                        }
                        break;
+               default:
+                       DEBUG(1, ("NTLMSSP state has invalid role %d\n",
+                                 gensec_ntlmssp->ntlmssp_state->role));
+                       return NT_STATUS_INVALID_PARAMETER;
                }
        } else {
                if (!msrpc_parse(gensec_ntlmssp->ntlmssp_state,