s4:ldap_server: remove pointless (result != LDAP_SUCCESS) check

We set result = LDAP_SUCCESS above and have goto do_reply;
in all cases where we overwrite 'result'.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/source4/ldap_server/ldap_bind.c b/source4/ldap_server/ldap_bind.c
index 6a88891152fcea2c792e8af6737147bf186c301b..7f14384f3595fa1892b72b2f050a1c883ba5ad8c 100644 (file)
--- a/source4/ldap_server/ldap_bind.c
+++ b/source4/ldap_server/ldap_bind.c
@@ -505,8 +505,7 @@ static NTSTATUS ldapsrv_BindSASL(struct ldapsrv_call *call)
                }
        }
 
-       if (result != LDAP_SUCCESS) {
-       } else if (!NT_STATUS_IS_OK(status)) {
+       if (!NT_STATUS_IS_OK(status)) {
                result = LDAP_OPERATIONS_ERROR;
                errstr = talloc_asprintf(reply,
                                         "SASL:[%s]: Failed to setup SASL socket: %s",