regmap: Don't warn about cache only mode for devices with no cache
authorMark Brown <broonie@kernel.org>
Wed, 22 Jun 2022 17:17:23 +0000 (18:17 +0100)
committerMark Brown <broonie@kernel.org>
Mon, 27 Jun 2022 12:21:59 +0000 (13:21 +0100)
For devices with no cache it can make sense to use cache only mode as a
mechanism for trapping writes to hardware which is inaccessible but since
no cache is equivalent to cache bypass we force such devices into bypass
mode. This means that our check that bypass and cache only mode aren't both
enabled simultanously is less sensible for devices without a cache so relax
it.

Signed-off-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20220622171723.1235749-1-broonie@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/base/regmap/regcache.c

index 2eaffd3224c9bbd3862cc1a43f5e654229dd7e6e..ef62ec225d81579ab61a0ffc1adf39a0f4084fde 100644 (file)
@@ -495,7 +495,8 @@ EXPORT_SYMBOL_GPL(regcache_drop_region);
 void regcache_cache_only(struct regmap *map, bool enable)
 {
        map->lock(map->lock_arg);
-       WARN_ON(map->cache_bypass && enable);
+       WARN_ON(map->cache_type != REGCACHE_NONE &&
+               map->cache_bypass && enable);
        map->cache_only = enable;
        trace_regmap_cache_only(map, enable);
        map->unlock(map->lock_arg);