tracing: Fix memory leak in set_trigger_filter()
authorSteven Rostedt (VMware) <rostedt@goodmis.org>
Mon, 10 Dec 2018 02:17:30 +0000 (21:17 -0500)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Tue, 11 Dec 2018 18:50:19 +0000 (13:50 -0500)
When create_event_filter() fails in set_trigger_filter(), the filter may
still be allocated and needs to be freed. The caller expects the
data->filter to be updated with the new filter, even if the new filter
failed (we could add an error message by setting set_str parameter of
create_event_filter(), but that's another update).

But because the error would just exit, filter was left hanging and
nothing could free it.

Found by kmemleak detector.

Cc: stable@vger.kernel.org
Fixes: bac5fb97a173a ("tracing: Add and use generic set_trigger_filter() implementation")
Reviewed-by: Tom Zanussi <tom.zanussi@linux.intel.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
kernel/trace/trace_events_trigger.c

index 2152d1e530cb5e8b8b1020840b1613b3099caebe..cd12ecb66eb9236e3ca741517ea55105d744ab6e 100644 (file)
@@ -732,8 +732,10 @@ int set_trigger_filter(char *filter_str,
 
        /* The filter is for the 'trigger' event, not the triggered event */
        ret = create_event_filter(file->event_call, filter_str, false, &filter);
-       if (ret)
-               goto out;
+       /*
+        * If create_event_filter() fails, filter still needs to be freed.
+        * Which the calling code will do with data->filter.
+        */
  assign:
        tmp = rcu_access_pointer(data->filter);