mmc: renesas_sdhi: complain loudly if driver needs update

When the tap array in the driver is too low, this is not a warning but
an error. Also _once is not helpful, we should make sure it is
prominently in the logs. It is safe to do this because this will only
show up during SoC enablement when we a new SoCs needs more taps (if
that ever will happen).

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Link: https://lore.kernel.org/r/20200129203709.30493-3-wsa+renesas@sang-engineering.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
index b3ab66f963f8c5f9bc5e702312ab43955564c19e..d63aeb35bd0b38a458e9fdfdb2393ec925636e94 100644 (file)
--- a/drivers/mmc/host/renesas_sdhi_core.c
+++ b/drivers/mmc/host/renesas_sdhi_core.c
@@ -499,9 +499,9 @@ static int renesas_sdhi_execute_tuning(struct tmio_mmc_host *host, u32 opcode)
                return 0; /* Tuning is not supported */
 
        if (host->tap_num * 2 >= sizeof(host->taps) * BITS_PER_BYTE) {
-               dev_warn_once(&host->pdev->dev,
-                       "Too many taps, skipping tuning. Please consider updating size of taps field of tmio_mmc_host\n");
-               return 0;
+               dev_err(&host->pdev->dev,
+                       "Too many taps, please update 'taps' in tmio_mmc_host!\n");
+               return -EINVAL;
        }
 
        priv->doing_tune = true;