crypto: Fix CID 1356314 Resource leak

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

diff --git a/source3/librpc/crypto/gse_krb5.c b/source3/librpc/crypto/gse_krb5.c
index b213e83f3b8ddbc8f6218c26876f0a246f23a998..e0021d08b56048d1a9830b2e250fb1bb13c4629d 100644 (file)
--- a/source3/librpc/crypto/gse_krb5.c
+++ b/source3/librpc/crypto/gse_krb5.c
@@ -144,6 +144,7 @@ static krb5_error_code fill_keytab_from_password(krb5_context krbctx,
 
                ret = krb5_unparse_name(krbctx, princ, &princ_s);
                if (ret != 0) {
+                       SAFE_FREE(key);
                        continue;
                }
 
@@ -152,12 +153,14 @@ static krb5_error_code fill_keytab_from_password(krb5_context krbctx,
                                                                        enctypes[i]);
                SAFE_FREE(princ_s);
                if (salt_princ_s == NULL) {
+                       SAFE_FREE(key);
                        continue;
                }
 
                ret = krb5_parse_name(krbctx, salt_princ_s, &salt_princ);
                SAFE_FREE(salt_princ_s);
                if (ret != 0) {
+                       SAFE_FREE(key);
                        continue;
                }