HID: hid-steam: Avoid overwriting smoothing parameter

The original implementation of this driver incorrectly guessed the function of
this register. It's not only unnecessary to write to this register for lizard
mode but actually counter-productive since it overwrites whatever previous
value was intentionally set, for example by Steam.

Signed-off-by: Vicki Pfau <vi@endrift.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>

diff --git a/drivers/hid/hid-steam.c b/drivers/hid/hid-steam.c
index b110818fc9458607d09610e4b6ee7e125c31c46f..7aefd52e945a192ff12641567cdd7d3c53b82a34 100644 (file)
--- a/drivers/hid/hid-steam.c
+++ b/drivers/hid/hid-steam.c
@@ -340,9 +340,6 @@ static void steam_set_lizard_mode(struct steam_device *steam, bool enable)
                steam_send_report_byte(steam, STEAM_CMD_DEFAULT_MAPPINGS);
                /* enable mouse */
                steam_send_report_byte(steam, STEAM_CMD_DEFAULT_MOUSE);
-               steam_write_registers(steam,
-                       STEAM_REG_RPAD_MARGIN, 0x01, /* enable margin */
-                       0);
 
                cancel_delayed_work_sync(&steam->heartbeat);
        } else {
@@ -351,7 +348,6 @@ static void steam_set_lizard_mode(struct steam_device *steam, bool enable)
 
                if (steam->quirks & STEAM_QUIRK_DECK) {
                        steam_write_registers(steam,
-                               STEAM_REG_RPAD_MARGIN, 0x00, /* disable margin */
                                STEAM_REG_LPAD_MODE, 0x07, /* disable mouse */
                                STEAM_REG_RPAD_MODE, 0x07, /* disable mouse */
                                STEAM_REG_LPAD_CLICK_PRESSURE, 0xFFFF, /* disable clicky pad */
@@ -365,7 +361,6 @@ static void steam_set_lizard_mode(struct steam_device *steam, bool enable)
                                schedule_delayed_work(&steam->heartbeat, 5 * HZ);
                } else {
                        steam_write_registers(steam,
-                               STEAM_REG_RPAD_MARGIN, 0x00, /* disable margin */
                                STEAM_REG_LPAD_MODE, 0x07, /* disable mouse */
                                STEAM_REG_RPAD_MODE, 0x07, /* disable mouse */
                                0);