ACPICA: Rename nameseg length macro/define for clarity
authorBob Moore <robert.moore@intel.com>
Mon, 8 Apr 2019 20:42:25 +0000 (13:42 -0700)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 9 Apr 2019 09:24:48 +0000 (11:24 +0200)
ACPICA commit 24870bd9e73d71e2a1ff0a1e94519f8f8409e57d

ACPI_NAME_SIZE changed to ACPI_NAMESEG_SIZE
This clarifies that this is the length of an individual
nameseg, not the length of a generic namestring/namepath.
Improves understanding of the code.

Link: https://github.com/acpica/acpica/commit/24870bd9
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Erik Schmauss <erik.schmauss@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
24 files changed:
drivers/acpi/acpi_configfs.c
drivers/acpi/acpica/aclocal.h
drivers/acpi/acpica/dbnames.c
drivers/acpi/acpica/evgpeinit.c
drivers/acpi/acpica/exnames.c
drivers/acpi/acpica/nsaccess.c
drivers/acpi/acpica/nsdump.c
drivers/acpi/acpica/nsnames.c
drivers/acpi/acpica/nsrepair2.c
drivers/acpi/acpica/nsutils.c
drivers/acpi/acpica/psargs.c
drivers/acpi/acpica/tbfind.c
drivers/acpi/acpica/tbprint.c
drivers/acpi/acpica/utascii.c
drivers/acpi/acpica/utdecode.c
drivers/acpi/acpica/utstring.c
drivers/acpi/sysfs.c
drivers/firmware/iscsi_ibft.c
drivers/thermal/intel/int340x_thermal/acpi_thermal_rel.c
include/acpi/actbl.h
include/acpi/actypes.h
tools/power/acpi/os_specific/service_layers/oslinuxtbl.c
tools/power/acpi/tools/acpidump/apdump.c
tools/power/acpi/tools/acpidump/apfiles.c

index 81bfc61972931caa91183b5a865940ecfd242143..f92033661239bea858d2a7288db062c2538f91a0 100644 (file)
@@ -109,7 +109,7 @@ static ssize_t acpi_table_signature_show(struct config_item *cfg, char *str)
        if (!h)
                return -EINVAL;
 
-       return sprintf(str, "%.*s\n", ACPI_NAME_SIZE, h->signature);
+       return sprintf(str, "%.*s\n", ACPI_NAMESEG_SIZE, h->signature);
 }
 
 static ssize_t acpi_table_length_show(struct config_item *cfg, char *str)
@@ -170,7 +170,7 @@ static ssize_t acpi_table_asl_compiler_id_show(struct config_item *cfg,
        if (!h)
                return -EINVAL;
 
-       return sprintf(str, "%.*s\n", ACPI_NAME_SIZE, h->asl_compiler_id);
+       return sprintf(str, "%.*s\n", ACPI_NAMESEG_SIZE, h->asl_compiler_id);
 }
 
 static ssize_t acpi_table_asl_compiler_revision_show(struct config_item *cfg,
index a2dfbf6b004e219f5a47a8664a8825d61672c174..13d513b81589207a4c9909e9577438310f4c5040 100644 (file)
@@ -293,7 +293,7 @@ acpi_status (*acpi_internal_method) (struct acpi_walk_state * walk_state);
  * expected_return_btypes - Allowed type(s) for the return value
  */
 struct acpi_name_info {
-       char name[ACPI_NAME_SIZE];
+       char name[ACPI_NAMESEG_SIZE];
        u16 argument_list;
        u8 expected_btypes;
 };
@@ -370,7 +370,7 @@ typedef acpi_status (*acpi_object_converter) (struct acpi_namespace_node *
                                              converted_object);
 
 struct acpi_simple_repair_info {
-       char name[ACPI_NAME_SIZE];
+       char name[ACPI_NAMESEG_SIZE];
        u32 unexpected_btypes;
        u32 package_index;
        acpi_object_converter object_converter;
index 004d34d9369bbcf6f91c84bce33214be1f23eb7f..63fe30e8680756989b1696f77fd517859316a0d4 100644 (file)
@@ -354,7 +354,7 @@ acpi_status acpi_db_find_name_in_namespace(char *name_arg)
        char acpi_name[5] = "____";
        char *acpi_name_ptr = acpi_name;
 
-       if (strlen(name_arg) > ACPI_NAME_SIZE) {
+       if (strlen(name_arg) > ACPI_NAMESEG_SIZE) {
                acpi_os_printf("Name must be no longer than 4 characters\n");
                return (AE_OK);
        }
index c92d2f6ebe014559ba37b60fc7fe8beb6b1ce5c5..b04f982e59fa8d0471d5f83296c95f50738579c9 100644 (file)
@@ -292,7 +292,7 @@ acpi_ev_match_gpe_method(acpi_handle obj_handle,
        acpi_status status;
        u32 gpe_number;
        u8 temp_gpe_number;
-       char name[ACPI_NAME_SIZE + 1];
+       char name[ACPI_NAMESEG_SIZE + 1];
        u8 type;
 
        ACPI_FUNCTION_TRACE(ev_match_gpe_method);
@@ -310,7 +310,7 @@ acpi_ev_match_gpe_method(acpi_handle obj_handle,
         * 1) Extract the method name and null terminate it
         */
        ACPI_MOVE_32_TO_32(name, &method_node->name.integer);
-       name[ACPI_NAME_SIZE] = 0;
+       name[ACPI_NAMESEG_SIZE] = 0;
 
        /* 2) Name must begin with an underscore */
 
index bd68d66e89f0da0e35d25a0910cbe4fff40f2cac..6b76be5212a470e8a5822b66cfadd7acc49d578d 100644 (file)
@@ -53,10 +53,10 @@ static char *acpi_ex_allocate_name_string(u32 prefix_count, u32 num_name_segs)
 
                /* Special case for root */
 
-               size_needed = 1 + (ACPI_NAME_SIZE * num_name_segs) + 2 + 1;
+               size_needed = 1 + (ACPI_NAMESEG_SIZE * num_name_segs) + 2 + 1;
        } else {
                size_needed =
-                   prefix_count + (ACPI_NAME_SIZE * num_name_segs) + 2 + 1;
+                   prefix_count + (ACPI_NAMESEG_SIZE * num_name_segs) + 2 + 1;
        }
 
        /*
@@ -141,7 +141,7 @@ static acpi_status acpi_ex_name_segment(u8 ** in_aml_address, char *name_string)
        }
 
        for (index = 0;
-            (index < ACPI_NAME_SIZE)
+            (index < ACPI_NAMESEG_SIZE)
             && (acpi_ut_valid_name_char(*aml_address, 0)); index++) {
                char_buf[index] = *aml_address++;
        }
index 75192b958544e0b5ef385cd64df27b2d7646d0ed..7b855603f81a5b81ad2a3d944165462b249fe4ab 100644 (file)
@@ -683,7 +683,7 @@ acpi_ns_lookup(union acpi_generic_state *scope_info,
 
                /* Point to next name segment and make this node current */
 
-               path += ACPI_NAME_SIZE;
+               path += ACPI_NAMESEG_SIZE;
                current_node = this_node;
        }
 
index 15070bd0c28a96596ded36274e258dc3da9594a1..1b12c172e115150e267d312413b4b7bdc6ce8ebe 100644 (file)
@@ -70,7 +70,7 @@ void acpi_ns_print_pathname(u32 num_segments, const char *pathname)
                            acpi_os_printf("?");
                }
 
-               pathname += ACPI_NAME_SIZE;
+               pathname += ACPI_NAMESEG_SIZE;
                num_segments--;
                if (num_segments) {
                        acpi_os_printf(".");
index c384320a0f269c45d556faf294e6487cded17546..370bbc8677453715ff56d459a02e37713ffddb81 100644 (file)
@@ -109,7 +109,7 @@ acpi_ns_handle_to_name(acpi_handle target_handle, struct acpi_buffer *buffer)
 
        node_name = acpi_ut_get_node_name(node);
        ACPI_COPY_NAMESEG(buffer->pointer, node_name);
-       ((char *)buffer->pointer)[ACPI_NAME_SIZE] = 0;
+       ((char *)buffer->pointer)[ACPI_NAMESEG_SIZE] = 0;
 
        ACPI_DEBUG_PRINT((ACPI_DB_EXEC, "%4.4s\n", (char *)buffer->pointer));
        return_ACPI_STATUS(AE_OK);
@@ -198,7 +198,7 @@ acpi_ns_build_normalized_path(struct acpi_namespace_node *node,
                              char *full_path, u32 path_size, u8 no_trailing)
 {
        u32 length = 0, i;
-       char name[ACPI_NAME_SIZE];
+       char name[ACPI_NAMESEG_SIZE];
        u8 do_no_trailing;
        char c, *left, *right;
        struct acpi_namespace_node *next_node;
@@ -446,7 +446,7 @@ static void acpi_ns_normalize_pathname(char *original_path)
 
                /* Do one nameseg at a time */
 
-               for (i = 0; (i < ACPI_NAME_SIZE) && *input_path; i++) {
+               for (i = 0; (i < ACPI_NAMESEG_SIZE) && *input_path; i++) {
                        if ((i == 0) || (*input_path != '_')) { /* First char is allowed to be underscore */
                                *new_path = *input_path;
                                new_path++;
index 4c285e9184654e58a07a92592254f11d4c90ff8d..8d776256b21318827de8de97eb365ad1dc35df3d 100644 (file)
@@ -25,7 +25,7 @@ acpi_status (*acpi_repair_function) (struct acpi_evaluate_info * info,
                                     return_object_ptr);
 
 typedef struct acpi_repair_info {
-       char name[ACPI_NAME_SIZE];
+       char name[ACPI_NAMESEG_SIZE];
        acpi_repair_function repair_function;
 
 } acpi_repair_info;
index 6f5940b02a4f03c37b46ee92c62cda56211ba2ac..6bc90d46db5caaf38b40684a7782a905f6181288 100644 (file)
@@ -178,7 +178,7 @@ void acpi_ns_get_internal_name_length(struct acpi_namestring_info *info)
                }
        }
 
-       info->length = (ACPI_NAME_SIZE * info->num_segments) +
+       info->length = (ACPI_NAMESEG_SIZE * info->num_segments) +
            4 + info->num_carats;
 
        info->next_external_char = next_external_char;
@@ -249,7 +249,7 @@ acpi_status acpi_ns_build_internal_name(struct acpi_namestring_info *info)
        /* Build the name (minus path separators) */
 
        for (; num_segments; num_segments--) {
-               for (i = 0; i < ACPI_NAME_SIZE; i++) {
+               for (i = 0; i < ACPI_NAMESEG_SIZE; i++) {
                        if (ACPI_IS_PATH_SEPARATOR(*external_name) ||
                            (*external_name == 0)) {
 
@@ -274,7 +274,7 @@ acpi_status acpi_ns_build_internal_name(struct acpi_namestring_info *info)
                /* Move on the next segment */
 
                external_name++;
-               result += ACPI_NAME_SIZE;
+               result += ACPI_NAMESEG_SIZE;
        }
 
        /* Terminate the string */
@@ -493,8 +493,8 @@ acpi_ns_externalize_name(u32 internal_name_length,
                                          &internal_name[names_index]);
                        acpi_ut_repair_name(&(*converted_name)[j]);
 
-                       j += ACPI_NAME_SIZE;
-                       names_index += ACPI_NAME_SIZE;
+                       j += ACPI_NAMESEG_SIZE;
+                       names_index += ACPI_NAMESEG_SIZE;
                }
        }
 
index 9d9d442cd999785d3624267ba6194ae5a034f8ce..e62c7897fdf18f7483bd2c4334dc81fe50bf3582 100644 (file)
@@ -150,21 +150,21 @@ char *acpi_ps_get_next_namestring(struct acpi_parse_state *parser_state)
 
                /* Two name segments */
 
-               end += 1 + (2 * ACPI_NAME_SIZE);
+               end += 1 + (2 * ACPI_NAMESEG_SIZE);
                break;
 
        case AML_MULTI_NAME_PREFIX:
 
                /* Multiple name segments, 4 chars each, count in next byte */
 
-               end += 2 + (*(end + 1) * ACPI_NAME_SIZE);
+               end += 2 + (*(end + 1) * ACPI_NAMESEG_SIZE);
                break;
 
        default:
 
                /* Single name segment */
 
-               end += ACPI_NAME_SIZE;
+               end += ACPI_NAMESEG_SIZE;
                break;
        }
 
@@ -522,7 +522,7 @@ static union acpi_parse_object *acpi_ps_get_next_field(struct acpi_parse_state
 
                ACPI_MOVE_32_TO_32(&name, parser_state->aml);
                acpi_ps_set_name(field, name);
-               parser_state->aml += ACPI_NAME_SIZE;
+               parser_state->aml += ACPI_NAMESEG_SIZE;
 
                ASL_CV_CAPTURE_COMMENTS_ONLY(parser_state);
 
index ddc88aaca376432b21e4b88bdafa6116b09d7e66..b2abb40023a6588c715f0130a1984c3be0ad3853 100644 (file)
@@ -65,7 +65,7 @@ acpi_tb_find_table(char *signature,
        (void)acpi_ut_acquire_mutex(ACPI_MTX_TABLES);
        for (i = 0; i < acpi_gbl_root_table_list.current_table_count; ++i) {
                if (memcmp(&(acpi_gbl_root_table_list.tables[i].signature),
-                          header.signature, ACPI_NAME_SIZE)) {
+                          header.signature, ACPI_NAMESEG_SIZE)) {
 
                        /* Not the requested table */
 
@@ -94,14 +94,14 @@ acpi_tb_find_table(char *signature,
 
                if (!memcmp
                    (acpi_gbl_root_table_list.tables[i].pointer->signature,
-                    header.signature, ACPI_NAME_SIZE) && (!oem_id[0]
-                                                          ||
-                                                          !memcmp
-                                                          (acpi_gbl_root_table_list.
-                                                           tables[i].pointer->
-                                                           oem_id,
-                                                           header.oem_id,
-                                                           ACPI_OEM_ID_SIZE))
+                    header.signature, ACPI_NAMESEG_SIZE) && (!oem_id[0]
+                                                             ||
+                                                             !memcmp
+                                                             (acpi_gbl_root_table_list.
+                                                              tables[i].
+                                                              pointer->oem_id,
+                                                              header.oem_id,
+                                                              ACPI_OEM_ID_SIZE))
                    && (!oem_table_id[0]
                        || !memcmp(acpi_gbl_root_table_list.tables[i].pointer->
                                   oem_table_id, header.oem_table_id,
index 0bc18fd5cd717330d87d0c9e9c5a10615eba2036..4764f849cb782fe99dd1073e43dba1fc0b56245d 100644 (file)
@@ -69,10 +69,10 @@ acpi_tb_cleanup_table_header(struct acpi_table_header *out_header,
 
        memcpy(out_header, header, sizeof(struct acpi_table_header));
 
-       acpi_tb_fix_string(out_header->signature, ACPI_NAME_SIZE);
+       acpi_tb_fix_string(out_header->signature, ACPI_NAMESEG_SIZE);
        acpi_tb_fix_string(out_header->oem_id, ACPI_OEM_ID_SIZE);
        acpi_tb_fix_string(out_header->oem_table_id, ACPI_OEM_TABLE_ID_SIZE);
-       acpi_tb_fix_string(out_header->asl_compiler_id, ACPI_NAME_SIZE);
+       acpi_tb_fix_string(out_header->asl_compiler_id, ACPI_NAMESEG_SIZE);
 }
 
 /*******************************************************************************
index 79d7426fd7bfbbeb1444f0a3df7319317218b5e3..f6cd7d4f698b3fff1ea1724a64f8ad39d42a5522 100644 (file)
@@ -30,7 +30,7 @@ u8 acpi_ut_valid_nameseg(char *name)
 
        /* Validate each character in the signature */
 
-       for (i = 0; i < ACPI_NAME_SIZE; i++) {
+       for (i = 0; i < ACPI_NAMESEG_SIZE; i++) {
                if (!acpi_ut_valid_name_char(name[i], i)) {
                        return (FALSE);
                }
index ad9f77eb554ffc7c55af007e75592091d7827c4e..76e054c83c396a1608abed67ce945f2f6a410653 100644 (file)
@@ -239,7 +239,7 @@ const char *acpi_ut_get_node_name(void *object)
 {
        struct acpi_namespace_node *node = (struct acpi_namespace_node *)object;
 
-       /* Must return a string of exactly 4 characters == ACPI_NAME_SIZE */
+       /* Must return a string of exactly 4 characters == ACPI_NAMESEG_SIZE */
 
        if (!object) {
                return ("NULL");
index 927797355da9df613ec43bd544c6e4913d534fc2..c39b5483045df0d98b4f98d8ec790a79abce9da3 100644 (file)
@@ -149,7 +149,7 @@ void acpi_ut_repair_name(char *name)
 
        /* Check each character in the name */
 
-       for (i = 0; i < ACPI_NAME_SIZE; i++) {
+       for (i = 0; i < ACPI_NAMESEG_SIZE; i++) {
                if (acpi_ut_valid_name_char(name[i], i)) {
                        continue;
                }
index 262d6ee4735dc5f379b4e6f524bdd5af137c9e0a..75948a3f1a20e7dffe04958e6905305afd12df96 100644 (file)
@@ -327,9 +327,9 @@ static struct kobject *hotplug_kobj;
 
 struct acpi_table_attr {
        struct bin_attribute attr;
-       char name[ACPI_NAME_SIZE];
+       char name[ACPI_NAMESEG_SIZE];
        int instance;
-       char filename[ACPI_NAME_SIZE+ACPI_INST_SIZE];
+       char filename[ACPI_NAMESEG_SIZE+ACPI_INST_SIZE];
        struct list_head node;
 };
 
@@ -383,7 +383,7 @@ static int acpi_table_attr_init(struct kobject *tables_obj,
        }
 
        ACPI_COPY_NAMESEG(table_attr->filename, table_header->signature);
-       table_attr->filename[ACPI_NAME_SIZE] = '\0';
+       table_attr->filename[ACPI_NAMESEG_SIZE] = '\0';
        if (table_attr->instance > 1 || (table_attr->instance == 1 &&
                                         !acpi_get_table
                                         (table_header->signature, 2, &header))) {
index c51462f5aa1e4f52d01cb7c88db42bdc006f7767..a5dc0629f2259d62e0b5fe9f4cbc8f10386742c1 100644 (file)
@@ -425,7 +425,7 @@ static ssize_t ibft_attr_show_acpitbl(void *data, int type, char *buf)
 
        switch (type) {
        case ISCSI_BOOT_ACPITBL_SIGNATURE:
-               str += sprintf_string(str, ACPI_NAME_SIZE,
+               str += sprintf_string(str, ACPI_NAMESEG_SIZE,
                                      entry->header->header.signature);
                break;
        case ISCSI_BOOT_ACPITBL_OEM_ID:
index 45e7e5cbdffb438648869b2ebd236b906ad82933..7c71ffb733a19d89797211f6530bd61ed60c010b 100644 (file)
@@ -230,7 +230,7 @@ static void get_single_name(acpi_handle handle, char *name)
        if (ACPI_FAILURE(acpi_get_name(handle, ACPI_SINGLE_NAME, &buffer)))
                pr_warn("Failed to get device name from acpi handle\n");
        else {
-               memcpy(name, buffer.pointer, ACPI_NAME_SIZE);
+               memcpy(name, buffer.pointer, ACPI_NAMESEG_SIZE);
                kfree(buffer.pointer);
        }
 }
index 65cc9cbf11415f83a0d82b32fa99e828369143e3..d568128025df8e848119ce5a247d5071c35ea745 100644 (file)
  ******************************************************************************/
 
 struct acpi_table_header {
-       char signature[ACPI_NAME_SIZE]; /* ASCII table signature */
+       char signature[ACPI_NAMESEG_SIZE];      /* ASCII table signature */
        u32 length;             /* Length of table in bytes, including this header */
        u8 revision;            /* ACPI Specification minor version number */
        u8 checksum;            /* To make sum of entire table == 0 */
        char oem_id[ACPI_OEM_ID_SIZE];  /* ASCII OEM identification */
        char oem_table_id[ACPI_OEM_TABLE_ID_SIZE];      /* ASCII OEM table identification */
        u32 oem_revision;       /* OEM revision number */
-       char asl_compiler_id[ACPI_NAME_SIZE];   /* ASCII ASL compiler vendor ID */
+       char asl_compiler_id[ACPI_NAMESEG_SIZE];        /* ASCII ASL compiler vendor ID */
        u32 asl_compiler_revision;      /* ASL compiler version */
 };
 
index cb51172a47a36fdc2291ba6f1290c72313a7ef98..ad6892a24015ee7fea303b163bc1d7f80e01dac9 100644 (file)
@@ -375,7 +375,7 @@ typedef u64 acpi_physical_address;
 
 /* Names within the namespace are 4 bytes long */
 
-#define ACPI_NAME_SIZE                  4
+#define ACPI_NAMESEG_SIZE               4      /* Fixed by ACPI spec */
 #define ACPI_PATH_SEGMENT_LENGTH        5      /* 4 chars for name + 1 char for separator */
 #define ACPI_PATH_SEPARATOR             '.'
 
@@ -518,8 +518,8 @@ typedef u64 acpi_integer;
 #define ACPI_COMPARE_NAMESEG(a,b)       (*ACPI_CAST_PTR (u32, (a)) == *ACPI_CAST_PTR (u32, (b)))
 #define ACPI_COPY_NAMESEG(dest,src)     (*ACPI_CAST_PTR (u32, (dest)) = *ACPI_CAST_PTR (u32, (src)))
 #else
-#define ACPI_COMPARE_NAMESEG(a,b)       (!strncmp (ACPI_CAST_PTR (char, (a)), ACPI_CAST_PTR (char, (b)), ACPI_NAME_SIZE))
-#define ACPI_COPY_NAMESEG(dest,src)     (strncpy (ACPI_CAST_PTR (char, (dest)), ACPI_CAST_PTR (char, (src)), ACPI_NAME_SIZE))
+#define ACPI_COMPARE_NAMESEG(a,b)       (!strncmp (ACPI_CAST_PTR (char, (a)), ACPI_CAST_PTR (char, (b)), ACPI_NAMESEG_SIZE))
+#define ACPI_COPY_NAMESEG(dest,src)     (strncpy (ACPI_CAST_PTR (char, (dest)), ACPI_CAST_PTR (char, (src)), ACPI_NAMESEG_SIZE))
 #endif
 
 /* Support for the special RSDP signature (8 characters) */
@@ -529,7 +529,7 @@ typedef u64 acpi_integer;
 
 /* Support for OEMx signature (x can be any character) */
 #define ACPI_IS_OEM_SIG(a)        (!strncmp (ACPI_CAST_PTR (char, (a)), ACPI_OEM_NAME, 3) &&\
-        strnlen (a, ACPI_NAME_SIZE) == ACPI_NAME_SIZE)
+        strnlen (a, ACPI_NAMESEG_SIZE) == ACPI_NAMESEG_SIZE)
 
 /*
  * Algorithm to obtain access bit width.
index 2686d858225ad52c779fabaeac8997de5e18eebb..d1f3d44e315eb71720cb8c9fbeb0fab87de15ae3 100644 (file)
@@ -19,7 +19,7 @@ ACPI_MODULE_NAME("oslinuxtbl")
 typedef struct osl_table_info {
        struct osl_table_info *next;
        u32 instance;
-       char signature[ACPI_NAME_SIZE];
+       char signature[ACPI_NAMESEG_SIZE];
 
 } osl_table_info;
 
@@ -995,7 +995,7 @@ static acpi_status osl_list_customized_tables(char *directory)
 {
        void *table_dir;
        u32 instance;
-       char temp_name[ACPI_NAME_SIZE];
+       char temp_name[ACPI_NAMESEG_SIZE];
        char *filename;
        acpi_status status = AE_OK;
 
@@ -1158,15 +1158,15 @@ osl_table_name_from_file(char *filename, char *signature, u32 *instance)
 
        /* Ignore meaningless files */
 
-       if (strlen(filename) < ACPI_NAME_SIZE) {
+       if (strlen(filename) < ACPI_NAMESEG_SIZE) {
                return (AE_BAD_SIGNATURE);
        }
 
        /* Extract instance number */
 
-       if (isdigit((int)filename[ACPI_NAME_SIZE])) {
-               sscanf(&filename[ACPI_NAME_SIZE], "%u", instance);
-       } else if (strlen(filename) != ACPI_NAME_SIZE) {
+       if (isdigit((int)filename[ACPI_NAMESEG_SIZE])) {
+               sscanf(&filename[ACPI_NAMESEG_SIZE], "%u", instance);
+       } else if (strlen(filename) != ACPI_NAMESEG_SIZE) {
                return (AE_BAD_SIGNATURE);
        } else {
                *instance = 0;
@@ -1311,7 +1311,7 @@ osl_get_customized_table(char *pathname,
 {
        void *table_dir;
        u32 current_instance = 0;
-       char temp_name[ACPI_NAME_SIZE];
+       char temp_name[ACPI_NAMESEG_SIZE];
        char table_filename[PATH_MAX];
        char *filename;
        acpi_status status;
index 9dfcc0329d34d3a18290cb0799ba0a8b1778af84..820baeb5092bd9d8bf19f1fcda31394058b57838 100644 (file)
@@ -289,14 +289,14 @@ int ap_dump_table_by_address(char *ascii_address)
 
 int ap_dump_table_by_name(char *signature)
 {
-       char local_signature[ACPI_NAME_SIZE + 1];
+       char local_signature[ACPI_NAMESEG_SIZE + 1];
        u32 instance;
        struct acpi_table_header *table;
        acpi_physical_address address;
        acpi_status status;
        int table_status;
 
-       if (strlen(signature) != ACPI_NAME_SIZE) {
+       if (strlen(signature) != ACPI_NAMESEG_SIZE) {
                fprintf(stderr,
                        "Invalid table signature [%s]: must be exactly 4 characters\n",
                        signature);
index 8abc8f998abd74cba0db67958ccc6fac67e75f70..a42cfcaa32938fb2923a84bbe59c09aac5c1526f 100644 (file)
@@ -97,7 +97,7 @@ int ap_open_output_file(char *pathname)
 
 int ap_write_to_binary_file(struct acpi_table_header *table, u32 instance)
 {
-       char filename[ACPI_NAME_SIZE + 16];
+       char filename[ACPI_NAMESEG_SIZE + 16];
        char instance_str[16];
        ACPI_FILE file;
        acpi_size actual;
@@ -119,7 +119,7 @@ int ap_write_to_binary_file(struct acpi_table_header *table, u32 instance)
        filename[1] = (char)tolower((int)filename[1]);
        filename[2] = (char)tolower((int)filename[2]);
        filename[3] = (char)tolower((int)filename[3]);
-       filename[ACPI_NAME_SIZE] = 0;
+       filename[ACPI_NAMESEG_SIZE] = 0;
 
        /* Handle multiple SSDts - create different filenames for each */