s4:ntlmssp: use a 'bool ok' helper variable to make the code more readable

metze

Signed-off-by: Günther Deschner <gd@samba.org>

diff --git a/source4/auth/ntlmssp/ntlmssp_sign.c b/source4/auth/ntlmssp/ntlmssp_sign.c
index 50ad2fdd3abd144b2ba409ac31f8ec833eb6d2ba..285369dbb3857e18c3f3cebc16c7352495e70875 100644 (file)
--- a/source4/auth/ntlmssp/ntlmssp_sign.c
+++ b/source4/auth/ntlmssp/ntlmssp_sign.c
@@ -114,12 +114,16 @@ static NTSTATUS ntlmssp_make_packet_signature(struct ntlmssp_state *ntlmssp_stat
                          (unsigned long long)pdu_length));
                dump_data(11, sig->data, sig->length);
        } else {
+               bool ok;
                uint32_t crc;
 
                crc = crc32_calc_buffer(data, length);
-               if (!msrpc_gen(sig_mem_ctx, 
-                              sig, "dddd", NTLMSSP_SIGN_VERSION, 0,
-                              crc, ntlmssp_state->crypt.ntlm.seq_num)) {
+
+               ok = msrpc_gen(sig_mem_ctx,
+                              sig, "dddd",
+                              NTLMSSP_SIGN_VERSION, 0, crc,
+                              ntlmssp_state->crypt.ntlm.seq_num);
+               if (!ok) {
                        return NT_STATUS_NO_MEMORY;
                }
                ntlmssp_state->crypt.ntlm.seq_num++;
@@ -264,12 +268,16 @@ NTSTATUS ntlmssp_seal_packet(struct ntlmssp_state *ntlmssp_state,
                                           sig->data+4, 8);
                }
        } else {
+               bool ok;
                uint32_t crc;
 
                crc = crc32_calc_buffer(data, length);
-               if (!msrpc_gen(sig_mem_ctx,
-                              sig, "dddd", NTLMSSP_SIGN_VERSION, 0,
-                              crc, ntlmssp_state->crypt.ntlm.seq_num)) {
+
+               ok = msrpc_gen(sig_mem_ctx,
+                              sig, "dddd",
+                              NTLMSSP_SIGN_VERSION, 0, crc,
+                              ntlmssp_state->crypt.ntlm.seq_num);
+               if (!ok) {
                        return NT_STATUS_NO_MEMORY;
                }