ldap_server: Fix CID 1435731 Unchecked return value
authorVolker Lendecke <vl@samba.org>
Tue, 22 May 2018 11:25:41 +0000 (13:25 +0200)
committerJeremy Allison <jra@samba.org>
Wed, 23 May 2018 22:43:51 +0000 (00:43 +0200)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source4/ldap_server/ldap_server.c

index 80b8c193be4b444e8ec0873a62a5c974a0afa0ad..49e03ef8c6f9c17e1267989ad696a382d6ecb444 100644 (file)
@@ -494,9 +494,17 @@ static bool ldapsrv_call_read_next(struct ldapsrv_connection *conn)
                return false;
        }
        if (!timeval_is_zero(&conn->limits.endtime)) {
-               tevent_req_set_endtime(subreq,
-                                      conn->connection->event.ctx,
-                                      conn->limits.endtime);
+               bool ok;
+               ok = tevent_req_set_endtime(subreq,
+                                           conn->connection->event.ctx,
+                                           conn->limits.endtime);
+               if (!ok) {
+                       ldapsrv_terminate_connection(
+                               conn,
+                               "ldapsrv_call_read_next: "
+                               "no memory for tevent_req_set_endtime");
+                       return false;
+               }
        }
        tevent_req_set_callback(subreq, ldapsrv_call_read_done, conn);
        conn->sockets.read_req = subreq;