arm: omap2: no need to check return value of debugfs_create functions
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 22 Jan 2019 14:41:14 +0000 (15:41 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 Jun 2019 13:49:07 +0000 (15:49 +0200)
When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Kevin Hilman <khilman@kernel.org>
Cc: Russell King <linux@armlinux.org.uk>
Cc: linux-omap@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/arm/mach-omap2/pm-debug.c

index 5a883920395862ba660fdea4af0ed30999af4593..1f9334a3d61163525e8365b58448bd385d8efcc3 100644 (file)
@@ -193,9 +193,8 @@ static int __init pwrdms_setup(struct powerdomain *pwrdm, void *dir)
                return 0;
 
        d = debugfs_create_dir(pwrdm->name, (struct dentry *)dir);
-       if (d)
-               (void) debugfs_create_file("suspend", S_IRUGO|S_IWUSR, d,
-                       (void *)pwrdm, &pwrdm_suspend_fops);
+       debugfs_create_file("suspend", S_IRUGO|S_IWUSR, d, pwrdm,
+                           &pwrdm_suspend_fops);
 
        return 0;
 }
@@ -233,16 +232,14 @@ static int __init pm_dbg_init(void)
                return 0;
 
        d = debugfs_create_dir("pm_debug", NULL);
-       if (!d)
-               return -EINVAL;
 
-       (void) debugfs_create_file("count", 0444, d, NULL, &pm_dbg_counters_fops);
-       (void) debugfs_create_file("time", 0444, d, NULL, &pm_dbg_timers_fops);
+       debugfs_create_file("count", 0444, d, NULL, &pm_dbg_counters_fops);
+       debugfs_create_file("time", 0444, d, NULL, &pm_dbg_timers_fops);
 
        pwrdm_for_each(pwrdms_setup, (void *)d);
 
-       (void) debugfs_create_file("enable_off_mode", S_IRUGO | S_IWUSR, d,
-                                  &enable_off_mode, &pm_dbg_option_fops);
+       debugfs_create_file("enable_off_mode", S_IRUGO | S_IWUSR, d,
+                           &enable_off_mode, &pm_dbg_option_fops);
        pm_dbg_init_done = 1;
 
        return 0;