docs: Don't push Sphinx upgrades quite so readily
authorJonathan Corbet <corbet@lwn.net>
Mon, 22 Jun 2020 22:31:21 +0000 (16:31 -0600)
committerJonathan Corbet <corbet@lwn.net>
Fri, 26 Jun 2020 15:31:53 +0000 (09:31 -0600)
The sphinx-pre-install script will put out a verbose message recommending
an upgrade for anybody running less than 2.4.4 - which was only released in
March.  So *everybody* will see that warning at this point.  Let's only
warn if the user is below our generally recommended version (1.7.9
currently).

It might be good to put out a warning if people are explicitly making PDF
files, but would need to be done in a different place and relatively few
people do that.

Signed-off-by: Jonathan Corbet <corbet@lwn.net>
scripts/sphinx-pre-install

index c680c3efb176ef7764f1538c6036ce436c8d8125..40fa6923e80aee97b447d3d8aea0362a99e36e02 100755 (executable)
@@ -323,10 +323,6 @@ sub check_sphinx()
                $rec_sphinx_upgrade = 1;
                return;
        }
-       if ($cur_version lt $min_pdf_version) {
-               $rec_sphinx_upgrade = 1;
-               return;
-       }
 
        # On version check mode, just assume Sphinx has all mandatory deps
        exit (0) if ($version_check);