If ldb_kv_filter_attrs() fails, we don't know that the dn of filtered_msg
is OK.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Apr 5 05:46:55 UTC 2019 on sn-devel-144
* assignment is safe
*/
ret = ldb_kv_filter_attrs(ctx, msg, ctx->attrs, &filtered_msg);
+ if (ret == -1) {
+ talloc_free(msg);
+ filtered_msg = NULL;
+ return LDB_ERR_OPERATIONS_ERROR;
+ }
/*
* Remove any extended components possibly copied in from
ldb_dn_remove_extended_components(filtered_msg->dn);
talloc_free(msg);
- if (ret == -1) {
- return LDB_ERR_OPERATIONS_ERROR;
- }
-
ret = ldb_module_send_entry(ctx->req, filtered_msg, NULL);
if (ret != LDB_SUCCESS) {
/* Regardless of success or failure, the msg