dmapool: speedup DMAPOOL_DEBUG with init_on_alloc
authorTony Battersby <tonyb@cybernetics.com>
Thu, 26 Jan 2023 21:51:18 +0000 (13:51 -0800)
committerAndrew Morton <akpm@linux-foundation.org>
Sat, 6 May 2023 17:33:36 +0000 (10:33 -0700)
Avoid double-memset of the same allocated memory in dma_pool_alloc() when
both DMAPOOL_DEBUG is enabled and init_on_alloc=1.

Link: https://lkml.kernel.org/r/20230126215125.4069751-6-kbusch@meta.com
Fixes: 2d55c16c0c54 ("dmapool: create/destroy cleanup")
Signed-off-by: Tony Battersby <tonyb@cybernetics.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Cc: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/dmapool.c

index ee993bb59fc277c78912c208a5678d891fb71864..eaed3ffb42aa88462ef5f1ca4cac6f4a5542abe5 100644 (file)
@@ -356,7 +356,7 @@ void *dma_pool_alloc(struct dma_pool *pool, gfp_t mem_flags,
                        break;
                }
        }
-       if (!(mem_flags & __GFP_ZERO))
+       if (!want_init_on_alloc(mem_flags))
                memset(retval, POOL_POISON_ALLOCATED, pool->size);
 #endif
        spin_unlock_irqrestore(&pool->lock, flags);