usb: phy: tegra: switch to using devm_gpiod_get()
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Mon, 5 Sep 2022 06:30:56 +0000 (23:30 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 5 Sep 2022 11:09:13 +0000 (13:09 +0200)
I would like to stop exporting OF-specific devm_gpiod_get_from_of_node()
so that gpiolib can be cleaned a bit, so let's switch to the generic
device property API.

I believe that the only reason the driver, instead of the standard
devm_gpiod_get(), used devm_gpiod_get_from_of_node() is because it
wanted to set up a pretty consumer name for the GPIO, and we now have
a special API for that.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Link: https://lore.kernel.org/r/20220903-gpiod_get_from_of_node-remove-v1-4-b29adfb27a6c@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/phy/phy-tegra-usb.c

index 68cd4b68e3a207f66a7a2fbdd9d6295cc4210111..f0240107edb15270d32ec67e19fe5dc200838665 100644 (file)
@@ -1440,16 +1440,22 @@ static int tegra_usb_phy_probe(struct platform_device *pdev)
                        return err;
                }
 
-               gpiod = devm_gpiod_get_from_of_node(&pdev->dev, np,
-                                                   "nvidia,phy-reset-gpio",
-                                                   0, GPIOD_OUT_HIGH,
-                                                   "ulpi_phy_reset_b");
+               gpiod = devm_gpiod_get(&pdev->dev, "nvidia,phy-reset",
+                                      GPIOD_OUT_HIGH);
                err = PTR_ERR_OR_ZERO(gpiod);
                if (err) {
                        dev_err(&pdev->dev,
                                "Request failed for reset GPIO: %d\n", err);
                        return err;
                }
+
+               err = gpiod_set_consumer_name(gpiod, "ulpi_phy_reset_b");
+               if (err) {
+                       dev_err(&pdev->dev,
+                               "Failed to set up reset GPIO name: %d\n", err);
+                       return err;
+               }
+
                tegra_phy->reset_gpio = gpiod;
 
                phy = devm_otg_ulpi_create(&pdev->dev,