]> git.samba.org - gd/samba-autobuild/.git/commitdiff
share_mode_lock.c: initialize out param
authorIsaac Boukris <iboukris@gmail.com>
Mon, 29 Jun 2020 08:42:09 +0000 (10:42 +0200)
committerIsaac Boukris <iboukris@sn-devel-184>
Tue, 30 Jun 2020 09:42:33 +0000 (09:42 +0000)
detected by covscan:
source3/locking/share_mode_lock.c:1563:6: warning: Branch condition evaluates to a garbage value

Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: David Mulder <dmulder@suse.com>
Autobuild-User(master): Isaac Boukris <iboukris@samba.org>
Autobuild-Date(master): Tue Jun 30 09:42:33 UTC 2020 on sn-devel-184

source3/locking/share_mode_lock.c

index adfa917df31760889836b4e16dfb9964e9d2cb90..a93141304b265daeb8d4d87674ae7985ed528e21 100644 (file)
@@ -1765,8 +1765,9 @@ static size_t share_mode_entry_find(
 {
        ssize_t left, right, middle;
 
+       *match = false;
+
        if (num_share_modes == 0) {
-               *match = false;
                return 0;
        }
 
@@ -1790,7 +1791,7 @@ static size_t share_mode_entry_find(
                ok = share_mode_entry_get(middle_ptr, e);
                if (!ok) {
                        DBG_DEBUG("share_mode_entry_get failed\n");
-                       return false;
+                       return 0;
                }
 
                cmp = share_mode_entry_cmp(
@@ -1807,7 +1808,6 @@ static size_t share_mode_entry_find(
                }
        }
 
-       *match = false;
        return left;
 }