s3 spoolss: arch needs to be set before it's passed to get_version_id.
authorTim Prouty <tprouty@samba.org>
Tue, 10 Feb 2009 00:12:20 +0000 (16:12 -0800)
committerTim Prouty <tprouty@samba.org>
Tue, 10 Feb 2009 00:12:20 +0000 (16:12 -0800)
7717ad688099860fa0989ed3582435404fd6d4fa left arch unitialized.

Guenther, please check.

source3/rpc_server/srv_spoolss_nt.c

index bbbf414e11cc429e897442ab96239ae5ff4bd059..a0b689c8a46bcec889af5f2157e5c9573a8540cb 100644 (file)
@@ -2019,6 +2019,9 @@ WERROR _spoolss_DeletePrinterDriver(pipes_struct *p,
                return WERR_ACCESS_DENIED;
        }
 
+       driver = CONST_DISCARD(char *, r->in.driver);
+       arch   = CONST_DISCARD(char *, r->in.architecture);
+
        /* check that we have a valid driver name first */
 
        if ((version=get_version_id(arch)) == -1)
@@ -2027,9 +2030,6 @@ WERROR _spoolss_DeletePrinterDriver(pipes_struct *p,
        ZERO_STRUCT(info);
        ZERO_STRUCT(info_win2k);
 
-       driver = CONST_DISCARD(char *, r->in.driver);
-       arch   = CONST_DISCARD(char *, r->in.architecture);
-
        if (!W_ERROR_IS_OK(get_a_printer_driver(&info, 3, driver, arch, version)))
        {
                /* try for Win2k driver if "Windows NT x86" */