ASoC: codecs: wm8994: use 'time_left' variable with wait_for_completion_timeout()
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Tue, 30 Apr 2024 11:54:36 +0000 (13:54 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 6 May 2024 15:00:15 +0000 (00:00 +0900)
There is a confusing pattern in the kernel to use a variable named 'timeout' to
store the result of wait_for_completion_timeout() causing patterns like:

timeout = wait_for_completion_timeout(...)
if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the code
self explaining.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/20240430115438.29134-4-wsa+renesas@sang-engineering.com
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wm8994.c

index fc9894975a1d59c26d8a62132e380b3650d8a84b..a99908582a50aa532ce72d8e3f618821b67785bf 100644 (file)
@@ -2210,7 +2210,7 @@ static int _wm8994_set_fll(struct snd_soc_component *component, int id, int src,
        int reg_offset, ret;
        struct fll_div fll;
        u16 reg, clk1, aif_reg, aif_src;
-       unsigned long timeout;
+       unsigned long time_left;
        bool was_enabled;
        struct clk *mclk;
 
@@ -2403,9 +2403,9 @@ static int _wm8994_set_fll(struct snd_soc_component *component, int id, int src,
                                    WM8994_FLL1_FRAC, reg);
 
                if (wm8994->fll_locked_irq) {
-                       timeout = wait_for_completion_timeout(&wm8994->fll_locked[id],
-                                                             msecs_to_jiffies(10));
-                       if (timeout == 0)
+                       time_left = wait_for_completion_timeout(&wm8994->fll_locked[id],
+                                                               msecs_to_jiffies(10));
+                       if (time_left == 0)
                                dev_warn(component->dev,
                                         "Timed out waiting for FLL lock\n");
                } else {