s3:smbd: Fix a possible null pointer deref in oplock code

Found by cppcheck.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/source3/smbd/oplock.c b/source3/smbd/oplock.c
index b6ac60fa4e14feec1efe1b9686b62a6760a3b736..d4062f7a66cdb64556c68a46c1f25a449d14886d 100644 (file)
--- a/source3/smbd/oplock.c
+++ b/source3/smbd/oplock.c
@@ -433,12 +433,11 @@ static void downgrade_lease_additional_trigger(struct tevent_context *ev,
                                            &state->lease_key,
                                            state->break_from,
                                            state->break_to);
-       TALLOC_FREE(state);
        if (!NT_STATUS_IS_OK(status)) {
                smbd_server_disconnect_client(state->client,
                                              nt_errstr(status));
-               return;
        }
+       TALLOC_FREE(state);
 }
 
 struct fsps_lease_update_state {