allan hourihane sent log 100 in which showed that some really old code

for lsa_close response was messing up.  fixed by calling lsa_io_r_close()
which i've been meaning to do for over eighteen months.
(This used to be commit f9a0ea09486b18a130ce1a1e5381ca61e0293c75)

diff --git a/source3/lsarpcd/srv_lsa.c b/source3/lsarpcd/srv_lsa.c
index 26153fca4738bec7370d984deb699990d43263c3..36259477da2fa048d5fdeb59d187597dbd6ebba7 100644 (file)
--- a/source3/lsarpcd/srv_lsa.c
+++ b/source3/lsarpcd/srv_lsa.c
@@ -571,23 +571,12 @@ static void api_lsa_lookup_names( pipes_struct *p, prs_struct *data,
 static void api_lsa_close( pipes_struct *p, prs_struct *data,
                                   prs_struct *rdata)
 {
-       /* XXXX this is NOT good */
-       char *q = mem_data(&(rdata->data), rdata->offset);
+       LSA_R_CLOSE r_c;
 
-       SIVAL(q, 0, 0);
-       q += 4;
-       SIVAL(q, 0, 0);
-       q += 4;
-       SIVAL(q, 0, 0);
-       q += 4;
-       SIVAL(q, 0, 0);
-       q += 4;
-       SIVAL(q, 0, 0); 
-       q += 4;
-       SIVAL(q, 0, 0);
-       q += 4;
+       ZERO_STRUCT(r_c);
 
-       rdata->offset += 24;
+       /* store the response in the SMB stream */
+       lsa_io_r_close("", &r_c, rdata, 0);
 }
 
 /***************************************************************************

diff --git a/source3/rpc_server/srv_lsa.c b/source3/rpc_server/srv_lsa.c
index 26153fca4738bec7370d984deb699990d43263c3..36259477da2fa048d5fdeb59d187597dbd6ebba7 100644 (file)
--- a/source3/rpc_server/srv_lsa.c
+++ b/source3/rpc_server/srv_lsa.c
@@ -571,23 +571,12 @@ static void api_lsa_lookup_names( pipes_struct *p, prs_struct *data,
 static void api_lsa_close( pipes_struct *p, prs_struct *data,
                                   prs_struct *rdata)
 {
-       /* XXXX this is NOT good */
-       char *q = mem_data(&(rdata->data), rdata->offset);
+       LSA_R_CLOSE r_c;
 
-       SIVAL(q, 0, 0);
-       q += 4;
-       SIVAL(q, 0, 0);
-       q += 4;
-       SIVAL(q, 0, 0);
-       q += 4;
-       SIVAL(q, 0, 0);
-       q += 4;
-       SIVAL(q, 0, 0); 
-       q += 4;
-       SIVAL(q, 0, 0);
-       q += 4;
+       ZERO_STRUCT(r_c);
 
-       rdata->offset += 24;
+       /* store the response in the SMB stream */
+       lsa_io_r_close("", &r_c, rdata, 0);
 }
 
 /***************************************************************************