ethernet: use eth_hw_addr_set() - casts
authorJakub Kicinski <kuba@kernel.org>
Fri, 1 Oct 2021 21:32:28 +0000 (14:32 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sat, 2 Oct 2021 13:18:26 +0000 (14:18 +0100)
eth_hw_addr_set() takes a u8 pointer, like other
etherdevice helpers. Convert the few drivers which
require casts because they memcpy from "endian marked"
types.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/3com/3c509.c
drivers/net/ethernet/cortina/gemini.c
drivers/net/ethernet/intel/e100.c

index 87c906e744fb72f60d817c49642cbeadbfd1fafa..846fa3af45040c18c24f137c460ea287edd822fc 100644 (file)
@@ -270,7 +270,7 @@ static void el3_dev_fill(struct net_device *dev, __be16 *phys_addr, int ioaddr,
 {
        struct el3_private *lp = netdev_priv(dev);
 
-       memcpy(dev->dev_addr, phys_addr, ETH_ALEN);
+       eth_hw_addr_set(dev, (u8 *)phys_addr);
        dev->base_addr = ioaddr;
        dev->irq = irq;
        dev->if_port = if_port;
index bcbe73374666d8b0d990dbf0af3dcac7d6c13be0..82d32caf1374c5bf0ef9e11540f827cacfaf79cf 100644 (file)
@@ -2467,7 +2467,7 @@ static int gemini_ethernet_port_probe(struct platform_device *pdev)
                       DEFAULT_NAPI_WEIGHT);
 
        if (is_valid_ether_addr((void *)port->mac_addr)) {
-               memcpy(netdev->dev_addr, port->mac_addr, ETH_ALEN);
+               eth_hw_addr_set(netdev, (u8 *)port->mac_addr);
        } else {
                dev_dbg(dev, "ethernet address 0x%08x%08x%08x invalid\n",
                        port->mac_addr[0], port->mac_addr[1],
index 09ae1939e6db4c7cc32e89708aa871763a543d91..b620fdfb15b9afdd11c25b7829ca880c415a06ed 100644 (file)
@@ -2921,7 +2921,7 @@ static int e100_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 
        e100_phy_init(nic);
 
-       memcpy(netdev->dev_addr, nic->eeprom, ETH_ALEN);
+       eth_hw_addr_set(netdev, (u8 *)nic->eeprom);
        if (!is_valid_ether_addr(netdev->dev_addr)) {
                if (!eeprom_bad_csum_allow) {
                        netif_err(nic, probe, nic->netdev, "Invalid MAC address from EEPROM, aborting\n");