pkt_sched: dev_init_scheduler() does not need to lock qdisc tree.
authorDavid S. Miller <davem@davemloft.net>
Wed, 16 Jul 2008 09:23:17 +0000 (02:23 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 18 Jul 2008 02:21:21 +0000 (19:21 -0700)
We are registering the device, there is no way anyone can get
at this object's qdiscs yet in any meaningful way.

Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_generic.c

index dd5c4e70abe4950050385248c48617918fd4533c..7e078c5931946ffb17b4220cdaa3e3aefa8fc6d9 100644 (file)
@@ -741,10 +741,8 @@ static void dev_init_scheduler_queue(struct net_device *dev,
 
 void dev_init_scheduler(struct net_device *dev)
 {
-       qdisc_lock_tree(dev);
        netdev_for_each_tx_queue(dev, dev_init_scheduler_queue, &noop_qdisc);
        dev_init_scheduler_queue(dev, &dev->rx_queue, NULL);
-       qdisc_unlock_tree(dev);
 
        setup_timer(&dev->watchdog_timer, dev_watchdog, (unsigned long)dev);
 }