mmc: renesas_sdhi: Use dev_err_probe when getting clock fails
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Wed, 10 Nov 2021 19:16:08 +0000 (20:16 +0100)
committerGeert Uytterhoeven <geert+renesas@glider.be>
Fri, 19 Nov 2021 10:32:39 +0000 (11:32 +0100)
This is to improve deferred probe in this driver and to keep consistent
with an up-to-date handling of a soon to be added second clock.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
Link: https://lore.kernel.org/r/20211110191610.5664-20-wsa+renesas@sang-engineering.com
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
drivers/mmc/host/renesas_sdhi_core.c

index 31e232bcb5e80c0fa6487e48722152834371cce6..7f842fd306a330a2a26c9cf1953489d480449c2a 100644 (file)
@@ -918,11 +918,8 @@ int renesas_sdhi_probe(struct platform_device *pdev,
        dma_priv = &priv->dma_priv;
 
        priv->clk = devm_clk_get(&pdev->dev, NULL);
-       if (IS_ERR(priv->clk)) {
-               ret = PTR_ERR(priv->clk);
-               dev_err(&pdev->dev, "cannot get clock: %d\n", ret);
-               return ret;
-       }
+       if (IS_ERR(priv->clk))
+               return dev_err_probe(&pdev->dev, PTR_ERR(priv->clk), "cannot get clock");
 
        /*
         * Some controllers provide a 2nd clock just to run the internal card