git.samba.org
/
bbaumbach
/
samba-autobuild
/
.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
72833e4
)
s4:smb_server/smb/trans2.c - "talloc_move" isn't strictly necessary here
author
Matthias Dieter Wallnöfer
<mdw@samba.org>
Thu, 24 Mar 2011 09:28:10 +0000
(10:28 +0100)
committer
Matthias Dieter Wallnöfer
<mdw@samba.org>
Wed, 30 Mar 2011 06:45:06 +0000
(08:45 +0200)
Since the "set" will be free'd afterwards "talloc_steal" is enough.
Reviewed-by: Tridge
source4/smb_server/smb/trans2.c
patch
|
blob
|
history
diff --git
a/source4/smb_server/smb/trans2.c
b/source4/smb_server/smb/trans2.c
index 416d6f04f15e655dea6f7ef47c449244eb7d87c6..0a6c014e88a7a99e548aacc1a77cde9df5d03a78 100644
(file)
--- a/
source4/smb_server/smb/trans2.c
+++ b/
source4/smb_server/smb/trans2.c
@@
-1487,7
+1487,7
@@
static NTSTATUS dodc_or_sysvol_referral(TALLOC_CTX *ctx,
NT_STATUS_HAVE_NO_MEMORY_AND_FREE(dc_list, context);
for(j=0; j<set[i]->count; j++) {
- dc_list[num_dcs + j] = talloc_
move(context, &
set[i]->names[j]);
+ dc_list[num_dcs + j] = talloc_
steal(context,
set[i]->names[j]);
}
num_dcs = num_dcs + set[i]->count;
TALLOC_FREE(set[i]);