ARM: orion/gpio: Make use of for_each_requested_gpio()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 15 Jun 2020 15:05:42 +0000 (18:05 +0300)
committerGregory CLEMENT <gregory.clement@bootlin.com>
Sat, 18 Jul 2020 20:49:23 +0000 (22:49 +0200)
Make use of for_each_requested_gpio() instead of home grown analogue.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Gregory Clement <gregory.clement@bootlin.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
arch/arm/plat-orion/gpio.c

index 26a531ebb6e950373e0ff6a0cd26e866558bc854..734f0be4f14a67af011706c10d164cf14ed80493 100644 (file)
@@ -442,6 +442,7 @@ static void orion_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)
 
        struct orion_gpio_chip *ochip = gpiochip_get_data(chip);
        u32 out, io_conf, blink, in_pol, data_in, cause, edg_msk, lvl_msk;
+       const char *label;
        int i;
 
        out     = readl_relaxed(GPIO_OUT(ochip));
@@ -453,15 +454,10 @@ static void orion_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)
        edg_msk = readl_relaxed(GPIO_EDGE_MASK(ochip));
        lvl_msk = readl_relaxed(GPIO_LEVEL_MASK(ochip));
 
-       for (i = 0; i < chip->ngpio; i++) {
-               const char *label;
+       for_each_requested_gpio(chip, i, label) {
                u32 msk;
                bool is_out;
 
-               label = gpiochip_is_requested(chip, i);
-               if (!label)
-                       continue;
-
                msk = 1 << i;
                is_out = !(io_conf & msk);