random: avoid initializing twice in credit race
authorJason A. Donenfeld <Jason@zx2c4.com>
Mon, 9 May 2022 11:40:55 +0000 (13:40 +0200)
committerJason A. Donenfeld <Jason@zx2c4.com>
Wed, 18 May 2022 13:53:53 +0000 (15:53 +0200)
commitfed7ef061686cc813b1f3d8d0edc6c35b4d3537b
treeb101b9afaba4dac30cbc74eff430fe7a6db0fa2e
parente3d2c5e79a999aa4e7d6f0127e16d3da5a4ff70d
random: avoid initializing twice in credit race

Since all changes of crng_init now go through credit_init_bits(), we can
fix a long standing race in which two concurrent callers of
credit_init_bits() have the new bit count >= some threshold, but are
doing so with crng_init as a lower threshold, checked outside of a lock,
resulting in crng_reseed() or similar being called twice.

In order to fix this, we can use the original cmpxchg value of the bit
count, and only change crng_init when the bit count transitions from
below a threshold to meeting the threshold.

Reviewed-by: Dominik Brodowski <linux@dominikbrodowski.net>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
drivers/char/random.c