r19132: Fix some C++ warnings. Is there interest to have them in Samba4 as well?
authorVolker Lendecke <vlendec@samba.org>
Fri, 6 Oct 2006 14:39:47 +0000 (14:39 +0000)
committerGerald (Jerry) Carter <jerry@samba.org>
Wed, 10 Oct 2007 17:15:15 +0000 (12:15 -0500)
commitfd1cf23567566b65cdeecdbc04f58f29e29edd79
treec37c3650eadf0ba8e39d25ffe8d59a43b8b74257
parentd898cbce90673d1f13d2fd0b2c8308af34e2fb9c
r19132: Fix some C++ warnings. Is there interest to have them in Samba4 as well?

I have some problems resolving the last 3 ones in attrib_handlers.c. In line
251 the function ldb_dn_explode_casefold is called with mem_ctx as the first
argument. Looking at ldb_dn_explode_casefold I see that the first argument it
expects is a struct ldb_context. I could certainly add a cast to (struct
ldb_context *) to that call, but I would assume that this is the wrong fix. Is
it possible that attrib_handlers.c:251 and :254 should have ldb and not
mem_ctx as the first argument?

Can anybody from Samba4 clarify this for me and apply the correct fix?

Thanks a lot.

Volker
(This used to be commit 26f2cb71ebf00b2c6f356da5f32384f7fa083521)
source3/lib/ldb/common/ldb.c
source3/lib/ldb/common/ldb_dn.c
source3/lib/ldb/common/ldb_ldif.c
source3/lib/ldb/common/ldb_modules.c
source3/lib/ldb/common/ldb_msg.c
source3/lib/ldb/common/ldb_parse.c