usb: cdns3: gadget: own the lock wrongly at the suspend routine
authorPeter Chen <peter.chen@nxp.com>
Thu, 29 Oct 2020 09:55:18 +0000 (17:55 +0800)
committerPeter Chen <peter.chen@nxp.com>
Fri, 30 Oct 2020 03:40:54 +0000 (11:40 +0800)
commite11d2bf271589e70ea80a2ee3e116c40fcac62c2
tree0628c1b77c99d7aa5c3eb7b0930994e93eda3424
parent52d3967704aea6cb316d419a33a5e1d56d33a3c1
usb: cdns3: gadget: own the lock wrongly at the suspend routine

When the system goes to suspend, if the controller is at device mode with
cable connecting to host, the call stack is: cdns3_suspend->
cdns3_gadget_suspend -> cdns3_disconnect_gadget, after cdns3_disconnect_gadget
is called, it owns lock wrongly, it causes the system being deadlock after
resume due to at cdns3_device_thread_irq_handler, it tries to get the lock,
but can't get it forever.

To fix it, we delete the unlock-lock operations at cdns3_disconnect_gadget,
and do it at the caller.

Fixes: b1234e3b3b26 ("usb: cdns3: add runtime PM support")
Acked-by: Pawel Laszczak <pawell@cadence.com>
Signed-off-by: Peter Chen <peter.chen@nxp.com>
drivers/usb/cdns3/gadget.c