Remove more "CHECK_DISPLAY_AS_DATA()" calls and "pinfo->current_proto ="
authorguy <guy@f5534014-38df-0310-8fa8-9805f1628bb7>
Thu, 25 Jan 2001 06:14:14 +0000 (06:14 +0000)
committerguy <guy@f5534014-38df-0310-8fa8-9805f1628bb7>
Thu, 25 Jan 2001 06:14:14 +0000 (06:14 +0000)
commitd6703cb426bce30ebc61f4b4afe7c0858440500e
treeb1874a0778b3163345ccecf56d1ae88804b2f7cb
parent3aaaefdd5c4f70166fc76793d24450c8b1fd21a0
Remove more "CHECK_DISPLAY_AS_DATA()" calls and "pinfo->current_proto ="
statements.

Move the setting of the Protocol column in various dissectors before
anything is fetched from the packet, and also clear the Info column at
that point in those and some other dissectors, so that if an exception
is thrown, the columns don't reflect the previous protocol.

"Tvbuffify" the Mobile IP dissector (it took old-style arguments, and
then converted them into tvbuff arguments, so there wasn't much to do,
other than to fix references to "fd" to refer to "pinfo->fd").

In the SCTP dissector, refer to the port type and source and destination
ports through "pinfo" rather than through the global "pi", as it's a
tvbuffified dissector.

In the SMTP and Time Protocol dissectors, use "pinfo->match_port" rather
than "TCP_PORT_SMTP" when checking whether the packet is a request or
reply, just in case somebody makes a non-standard port be dissected as
SMTP or Time.  (Also, remove a bogus comment from the Time dissector; it
was probably cut-and-pasted from the TFTP dissector.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2938 f5534014-38df-0310-8fa8-9805f1628bb7
24 files changed:
packet-ascend.c
packet-auto_rp.c
packet-cdp.c
packet-cgmp.c
packet-dec-bpdu.c
packet-fr.c
packet-iua.c
packet-l2tp.c
packet-lapbether.c
packet-ldp.c
packet-m3ua.c
packet-mapi.c
packet-mip.c
packet-mpls.c
packet-rtsp.c
packet-sap.c
packet-sctp.c
packet-sdp.c
packet-sip.c
packet-smtp.c
packet-sna.c
packet-syslog.c
packet-telnet.c
packet-time.c