seqlock/latch: Provide raw_read_seqcount_latch_retry()
authorPeter Zijlstra <peterz@infradead.org>
Fri, 19 May 2023 10:20:59 +0000 (12:20 +0200)
committerPeter Zijlstra <peterz@infradead.org>
Mon, 5 Jun 2023 19:11:03 +0000 (21:11 +0200)
commitd16317de9b412aa7bd3598c607112298e36b4352
tree977e3a5e3befafc5121fc66e1399ab2909beeb82
parent8f2d6c41e5a649fe217724364cbb1a7d2e6ff205
seqlock/latch: Provide raw_read_seqcount_latch_retry()

The read side of seqcount_latch consists of:

  do {
    seq = raw_read_seqcount_latch(&latch->seq);
    ...
  } while (read_seqcount_latch_retry(&latch->seq, seq));

which is asymmetric in the raw_ department, and sure enough,
read_seqcount_latch_retry() includes (explicit) instrumentation where
raw_read_seqcount_latch() does not.

This inconsistency becomes a problem when trying to use it from
noinstr code. As such, fix it by renaming and re-implementing
raw_read_seqcount_latch_retry() without the instrumentation.

Specifically the instrumentation in question is kcsan_atomic_next(0)
in do___read_seqcount_retry(). Loosing this annotation is not a
problem because raw_read_seqcount_latch() does not pass through
kcsan_atomic_next(KCSAN_SEQLOCK_REGION_MAX).

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Tested-by: Michael Kelley <mikelley@microsoft.com> # Hyper-V
Link: https://lore.kernel.org/r/20230519102715.233598176@infradead.org
include/linux/rbtree_latch.h
include/linux/seqlock.h
kernel/printk/printk.c
kernel/time/sched_clock.c
kernel/time/timekeeping.c