netfilter: nf_flow_table: fix big-endian integer overflow
authorArnd Bergmann <arnd@arndb.de>
Tue, 10 Dec 2019 20:24:28 +0000 (21:24 +0100)
committerPablo Neira Ayuso <pablo@netfilter.org>
Fri, 20 Dec 2019 01:12:18 +0000 (02:12 +0100)
commitc9b3b8207bc487de02cbca968927ba2c2cb46aaf
tree8d9da00ea367d2926c669c6b4886b8845f6d1370
parent0fd260056ef84ede8f444c66a3820811691fe884
netfilter: nf_flow_table: fix big-endian integer overflow

In some configurations, gcc reports an integer overflow:

net/netfilter/nf_flow_table_offload.c: In function 'nf_flow_rule_match':
net/netfilter/nf_flow_table_offload.c:80:21: error: unsigned conversion from 'int' to '__be16' {aka 'short unsigned int'} changes value from '327680' to '0' [-Werror=overflow]
   mask->tcp.flags = TCP_FLAG_RST | TCP_FLAG_FIN;
                     ^~~~~~~~~~~~

From what I can tell, we want the upper 16 bits of these constants,
so they need to be shifted in cpu-endian mode.

Fixes: c29f74e0df7a ("netfilter: nf_flow_table: hardware offload support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_flow_table_offload.c