powerpc/64s/hash: improve context tracking of hash faults
authorNicholas Piggin <npiggin@gmail.com>
Sat, 30 Jan 2021 13:08:41 +0000 (23:08 +1000)
committerMichael Ellerman <mpe@ellerman.id.au>
Mon, 8 Feb 2021 13:02:12 +0000 (00:02 +1100)
commita008f8f9fd67ffb13d906ef4ea6235a3d62dfdb6
treeb46363cdf1768c3aad470434f58a5ed9f29b7983
parent2a06bf3e95cd93e3640d431960181b8e47415f33
powerpc/64s/hash: improve context tracking of hash faults

This moves the 64s/hash context tracking from hash_page_mm() to
__do_hash_fault(), so it's no longer called by OCXL / SPU
accelerators, which was certainly the wrong thing to be doing,
because those callers are not low level interrupt handlers, so
should have entered a kernel context tracking already.

Then remain in kernel context for the duration of the fault,
rather than enter/exit for the hash fault then enter/exit for
the page fault, which is pointless.

Even still, calling exception_enter/exit in __do_hash_fault seems
questionable because that's touching per-cpu variables, tracing,
etc., which might have been interrupted by this hash fault or
themselves cause hash faults. But maybe I miss something because
hash_page_mm very deliberately calls trace_hash_fault too, for
example. So for now go with it, it's no worse than before, in this
regard.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20210130130852.2952424-32-npiggin@gmail.com
arch/powerpc/include/asm/bug.h
arch/powerpc/mm/book3s64/hash_utils.c
arch/powerpc/mm/fault.c