power: supply: qcom_battmgr: remove bogus do_div()
authorArnd Bergmann <arnd@arndb.de>
Tue, 14 Feb 2023 13:20:42 +0000 (14:20 +0100)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 1 Mar 2023 18:41:18 +0000 (10:41 -0800)
commit92304df83b943776492309f42452effea0cc1089
tree2516084fd0a154b117038f6712eb11353ea1b5de
parentf122a08b197d076ccf136c73fae0146875812a88
power: supply: qcom_battmgr: remove bogus do_div()

The argument to do_div() is a 32-bit integer, and it was read from a
32-bit register so there is no point in doing a 64-bit division on it.

On 32-bit arm, do_div() causes a compile-time warning here:

    include/asm-generic/div64.h:238:22: error: passing argument 1 of '__div64_32' from incompatible pointer type [-Werror=incompatible-pointer-types]
      238 |   __rem = __div64_32(&(n), __base); \
          |                      ^~~~
          |                      |
          |                      unsigned int *
    drivers/power/supply/qcom_battmgr.c:1130:4: note: in expansion of macro 'do_div'
     1130 |    do_div(battmgr->status.percent, 100);

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/power/supply/qcom_battmgr.c