drm/bridge: panel: Prevent ERR_PTR Dereference
authorMaxime Ripard <maxime@cerno.tech>
Mon, 2 Jan 2023 12:01:23 +0000 (13:01 +0100)
committerMaxime Ripard <maxime@cerno.tech>
Thu, 5 Jan 2023 07:50:05 +0000 (08:50 +0100)
commit8dd4e8c49efc5a7a3879e117e4aa58082734506e
tree16681bf12e0b8e91f5dd9ee3ddaf84c14b3f82f1
parent51342cc021400841b461cc579f76db24cdb482fc
drm/bridge: panel: Prevent ERR_PTR Dereference

Commit 5ea6b1702781 ("drm/panel: Add prepare_prev_first flag to
drm_panel") introduced an access to the bridge pointer in the
devm_drm_panel_bridge_add_typed() function.

However, due to the unusual ERR_PTR check when getting that pointer, the
pointer access is done even though the pointer might be an error
pointer.

Rework the function for a more traditional design that will return
immediately if it gets an ERR_PTR so that we never access the pointer in
that case.

Fixes: 5ea6b1702781 ("drm/panel: Add prepare_prev_first flag to drm_panel")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20230102120123.19062-1-maxime@cerno.tech
Link: https://patchwork.freedesktop.org/patch/msgid/20230102120123.19062-1-maxime@cerno.tech
drivers/gpu/drm/bridge/panel.c