ARM: OMAP2+: Fix -Warray-bounds warning in _pwrdm_state_switch()
authorGustavo A. R. Silva <gustavoars@kernel.org>
Thu, 8 Jun 2023 04:12:11 +0000 (22:12 -0600)
committerTony Lindgren <tony@atomide.com>
Wed, 14 Jun 2023 08:11:17 +0000 (11:11 +0300)
commit847fb80cc01a54bc827b02547bb8743bdb59ddab
tree5a274ed2474d4d5c3599592ed85d7fa89578d341
parentc63f5b454885b191483cb67a43892f92ec99eca2
ARM: OMAP2+: Fix -Warray-bounds warning in _pwrdm_state_switch()

If function pwrdm_read_prev_pwrst() returns -EINVAL, we will end
up accessing array pwrdm->state_counter through negative index
-22. This is wrong and the compiler is legitimately warning us
about this potential problem.

Fix this by sanity checking the value stored in variable _prev_
before accessing array pwrdm->state_counter.

Address the following -Warray-bounds warning:
arch/arm/mach-omap2/powerdomain.c:178:45: warning: array subscript -22 is below array bounds of 'unsigned int[4]' [-Warray-bounds]

Link: https://github.com/KSPP/linux/issues/307
Fixes: ba20bb126940 ("OMAP: PM counter infrastructure.")
Cc: stable@vger.kernel.org
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/lkml/20230607050639.LzbPn%25lkp@intel.com/
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Message-ID: <ZIFVGwImU3kpaGeH@work>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
arch/arm/mach-omap2/powerdomain.c