git.samba.org / vlendec / samba-autobuild / .git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 785b5f6) | patch
smbd: Streamline the gids handling in create_token_from_sid()
authorVolker Lendecke <vl@samba.org>
Tue, 10 Mar 2015 20:03:15 +0000 (21:03 +0100)
committerJeremy Allison <jra@samba.org>
Wed, 11 Mar 2015 15:11:08 +0000 (16:11 +0100)
commit64a0724c6e69040f51c350e0e10f9d838f34c6b7
tree1ebafe986d615a52b35e5b89f2b5ab7a185b93b7tree
parent785b5f698fcd9be4da1d109db35d2ddc32130d15commit | diff
smbd: Streamline the gids handling in create_token_from_sid()

Usually, I'm all for avoiding talloc. But in this case I believe that this
routine is complex enough to justify this change. For an hour or so I suspect
that the winbind case had an uninitialized "*gid" until I discovered the
sid_to_gid(). This makes it more obvious that *gid is assigned.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source3/auth/token_util.c diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.