drm/i915: Kill GEN_FOREVER
authorRodrigo Vivi <rodrigo.vivi@intel.com>
Fri, 26 Oct 2018 19:51:43 +0000 (12:51 -0700)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Mon, 29 Oct 2018 17:44:15 +0000 (10:44 -0700)
commit5bc0e89ff1bee1566bd2fbd1142dce001c068aeb
tree5b5a297b5fd9f98b1d09e7deafc20aa241e7c9a2
parent9e7833758b9feebc37b9988d13b017534c90a4a2
drm/i915: Kill GEN_FOREVER

commit ac657f6461e5 ("drm/i915: Introduce IS_GEN macro") introduced
GEN_FOREVER that was never used.

My first attempt was to rename it to FOREVER since GEN is
already part of the macro. Then I used coccinelle to change all
-INTEL_GEN(e1) >= e2
+INTEL_GEN_RANGE(e1, e2, FOREVER)
-INTEL_GEN(e1) <= e2
+INTEL_GEN_RANGE(e1, 0, e2)

and I liked it.

However I didn't like very much the remaining
INTEL_GEN(dev_priv) < n

and:
INTEL_GEN(e1) < n
INTEL_GEN_RANGE(e1, 0, n - 1)

didn't make much sense either.

So INTEL_GEN use for > or < seems a better unified way for unlimited
bounds. So, no reason to keep GEN_FOREVER here.

Let's kill before someone start using it.

v2: Remove remaining GEN_FOREVER forgotten in a comment. (Daniel)

Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20181026195143.20353-2-rodrigo.vivi@intel.com
drivers/gpu/drm/i915/i915_drv.h