Revert "HID: usbhid: do not sleep when opening device"
authorJiri Kosina <jkosina@suse.cz>
Tue, 18 Aug 2020 17:54:04 +0000 (19:54 +0200)
committerJiri Kosina <jkosina@suse.cz>
Tue, 18 Aug 2020 17:54:04 +0000 (19:54 +0200)
commit5b0545dc184442fa509a311b8c855370441ad5bc
tree83e837a88256849230b8dda787357666dc0ef774
parent25a097f5204675550afb879ee18238ca917cba7a
Revert "HID: usbhid: do not sleep when opening device"

This reverts commit d3132792285859253c466354fd8d54d1fe0ba786.

This patch causes a regression with quite a few devices, as probing fails
because of the race where the first IRQ is dropped on the floor (after
hid_device_io_start() happens, but before the 50ms timeout passess), and
report descriptor never gets parsed and populated.

As this is just a boot time micro-optimization, let's revert the
patch for 5.9 now, and fix this properly eventually for next merge
window.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=208935
Reported-by: Johannes Hirte <johannes.hirte@datenkhaos.de>
Reported-by: Marius Zachmann <mail@mariuszachmann.de>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/usbhid/hid-core.c
drivers/hid/usbhid/usbhid.h